From mboxrd@z Thu Jan 1 00:00:00 1970 From: Armando VISCONTI Date: Mon, 26 Apr 2010 10:01:40 +0200 Subject: [U-Boot] [PATCH 07/17] SPEAr : Network driver support added In-Reply-To: <4BD51E79.4020401@gmail.com> References: <1271836483-15978-1-git-send-email-vipin.kumar@st.com> <1271836483-15978-2-git-send-email-vipin.kumar@st.com> <1271836483-15978-3-git-send-email-vipin.kumar@st.com> <1271836483-15978-4-git-send-email-vipin.kumar@st.com> <1271836483-15978-5-git-send-email-vipin.kumar@st.com> <1271836483-15978-6-git-send-email-vipin.kumar@st.com> <1271836483-15978-7-git-send-email-vipin.kumar@st.com> <1271836483-15978-8-git-send-email-vipin.kumar@st.com> <4BCF3A89.2070607@gmail.com> <4BD17747.2010307@st.com> <4BD51E79.4020401@gmail.com> Message-ID: <4BD54864.4020403@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ben, > I agree that MDIO bus probing doesn't make much sense. I don't know > anything about your SOC, but the ones that I work with typically have > multiple MACs (data link) but only one MDIO bus (control link). The > end result is multiple PHYs on a multi-drop bus, and there's no way of > knowing which one has its data link connected to which MAC. > > I'd prefer to see it hard-coded, either through a CONFIG option or an > environment variable. In our SoC current architecture there are multiple sdio buses, basically one for each MAC. Neverthelees this architecture might change in the future. Moreover, I agree that driver should be generic, so I guess that we might add a phy_addr field in the device structure and pass it thru the initialize routine, as the macb driver is doing. In the meantime I saw that Vipin already provided a V2 of the driver, which is still in the old way. Vipin, can you possibly provide your comments? Thanks, Arm -- -- "Every step appears to be the unavoidable consequence of the -- preceding one." (A. Einstein) -- Armando Visconti Mobile: (+39) 346 8879146 Senior SW Engineer Fax: (+39) 02 93519290 CPG Work: (+39) 02 93519683 Computer System Division e-mail: armando.visconti at st.com ST Microelectronics TINA: 051 4683