[U-Boot] [PATCH 07/17] SPEAr : Network driver support added

[Vipin KUMAR <vipin.kumar@st.com>]

On 4/26/2010 1:31 PM, Armando VISCONTI wrote:
> Hi Ben,
> 
>> I agree that MDIO bus probing doesn't make much sense.  I don't know
>> anything about your SOC, but the ones that I work with typically have
>> multiple MACs (data link) but only one MDIO bus (control link).  The
>> end result is multiple PHYs on a multi-drop bus, and there's no way of
>> knowing which one has its data link connected to which MAC.
>>
>> I'd prefer to see it hard-coded, either through a CONFIG option or an
>> environment variable.
> In our SoC current architecture there are multiple sdio buses, basically
> one for each MAC.
> Neverthelees this architecture might change in the future.
> 
> Moreover, I agree that driver should be generic, so I guess that we
> might add a phy_addr field
> in the device structure and pass it thru the initialize routine, as the
> macb driver is doing.
> 
> In the meantime I saw that Vipin already provided a V2 of the driver,
> which is still in the old
> way.
> Vipin, can you possibly provide your comments?
> 

Actually speaking, I was waiting for a patch from Ben and this issue to
get resolved by then.
Seeing no reply from Ben, I sent a patch v2 to get the comments at least
on other subpatches. 
I think the suggested changes are fine and can be made in patch v3

> Thanks,
> Arm
> 
> 
> 
>