From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MX31: Adjust default environment for QONG module
Date: Wed, 28 Apr 2010 18:10:15 +0200 [thread overview]
Message-ID: <4BD85DE7.5030109@denx.de> (raw)
In-Reply-To: <20100428152923.45511AFC6AC@gemini.denx.de>
Wolfgang Denk wrote:
>> "ramdisk_addr=a0300000\0" \
> =========^^^^^^^^^^^^^^^^^^^^^
>
>> "u-boot=qong/u-boot.bin\0" \
>> "kernel_addr_r=80800000\0" \
>> @@ -274,7 +274,7 @@ extern int qong_nand_rdy(void *chip);
>> #define CONFIG_FLASH_CFI_MTD
>> #define MTDIDS_DEFAULT "nor0=physmap-flash.0"
>> #define MTDPARTS_DEFAULT \
>> - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \
>> + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \
>> "128k(env2),2560k(kernel),13m(ramdisk),-(user)"
>
> This shifts the start address of the "ramdisk' and "user" partitions
> to some odd addresses; also, this makes the definition of
> "ramdisk_addr" (see above) incorrct.
You are right. The ramdisk_addr must be shifted, or the kernel size must
be adjusted.
> I recommend to do this instead:
>
> - "mtdparts=physmap-flash.0:256k(U-Boot),128k(env1)," \
> - "128k(env2),2560k(kernel),13m(ramdisk),-(user)"
> + "mtdparts=physmap-flash.0:384k(U-Boot),128k(env1)," \
> + "128k(env2),2432k(kernel),13m(ramdisk),-(user)"
>
>
> What do you think?
Agree. I will send a new version of the patch with your proposed values.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2010-04-28 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 11:58 [U-Boot] [PATCH] MX31: Adjust default environment for QONG module Stefano Babic
2010-04-28 15:29 ` Wolfgang Denk
2010-04-28 16:10 ` Stefano Babic [this message]
2010-04-28 16:45 ` [U-Boot] [PATCH V2] " Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD85DE7.5030109@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox