From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC] OMAP: mmc: add support for second and third mmc channels
Date: Thu, 29 Apr 2010 13:15:14 -0500 [thread overview]
Message-ID: <4BD9CCB2.1090203@freescale.com> (raw)
In-Reply-To: <x2m5e088bd91004291100j11abda5ai93e51ca49803997@mail.gmail.com>
Steve Sakoman wrote:
> This patch adds support for the second and third mmc channels on OMAP3
> processors
>
> Boards wishing to use this feature should define
> CONFIG_SYS_MMC_SET_DEV in the board config
>
> Tested on Overo
>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
> ---
>
> diff --git a/arch/arm/include/asm/arch-omap3/mmc_host_def.h
> b/arch/arm/include/asm/arch-omap3/mmc_host_def.h
> index aa751c9..f081b43 100644
> --- a/arch/arm/include/asm/arch-omap3/mmc_host_def.h
> +++ b/arch/arm/include/asm/arch-omap3/mmc_host_def.h
> @@ -31,11 +31,18 @@
> typedef struct t2 {
> unsigned char res1[0x274];
> unsigned int devconf0; /* 0x274 */
> - unsigned char res2[0x2A8];
> + unsigned char res2[0x064];
> + unsigned int devconf1; /* 0x2D8 */
> + unsigned char res3[0x248];
> unsigned int pbias_lite; /* 0x520 */
This changes the offset of pbias_lite -- 0x64+4+0x248 = 0x2b0, not 0x2a8.
The mandatory use of structs even with large reserved areas seems to
invite and obscure such issues (and the comments don't help much, since
nothing ensures they're accurate).
-Scott
next prev parent reply other threads:[~2010-04-29 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 18:00 [U-Boot] [PATCH RFC] OMAP: mmc: add support for second and third mmc channels Steve Sakoman
2010-04-29 18:15 ` Scott Wood [this message]
2010-04-29 19:55 ` Steve Sakoman
2010-04-29 20:20 ` Steve Sakoman
2010-04-29 20:26 ` [U-Boot] [PATCH RFC v2] " Steve Sakoman
[not found] ` <p2q2acbd3e41004291338o8d7cb82dk42a9965b19d3da3f@mail.gmail.com>
2010-04-29 21:11 ` Steve Sakoman
2010-05-11 19:17 ` Philip Balister
2010-05-14 18:29 ` Andy Fleming
2010-06-18 22:43 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD9CCB2.1090203@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox