[U-Boot] [PATCH v2 00/17] Network support for spear platform and spear1300 support

[Tom Rix <tom@bumblecow.com>]

Vipin KUMAR wrote:
> Hello Tom/Wolfgang,
> Didn't see any feedbacks on this patchset. 
> Please let me know if the patch is good or should I make changes and resubmit
>  

Vipin,
I will provide you with complete review of your patch set this weekend.

Please use MAKEALL arm to check for regressions.
There is a compile error for spear310 and spear320.
Here is the spear310 error, spear320 is similar

	spear310.c: In function 'board_eth_init':
	spear310.c:64: warning: implicit declaration of function 'dw_mii_initialize'
	board/spear/spear310/libspear310.a(spear310.o): In function `board_eth_init':
	.../u-boot/src/u-boot-arm/board/spear/spear310/spear310.c:64: undefined 
reference to `dw_mii_initialize'

This error must be resolved.

FYI my email address has changed to tom at bumblecow.com.

Tom


> Thanks in advance
> 
> Regards
> Vipin
> 
> On 4/26/2010 8:26 AM, Vipin KUMAR wrote:
>> Hi,
>> The following subpatches incorporate review comments given on patch-set v1.
>> Please consider it for inclusion in mainline
>>
>> Thanks and Regards
>> Vipin
>>
>> Vipin Kumar (17):
>>   u-boot.img file not created when srctree and objtree are different
>>   change_bit routine defined
>>   SPEAr : SMI erase and write timeouts increased
>>   SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET
>>   SPEAr : Reducing the max RAM size to 128MB
>>   SPEAr : Basic arch related support added for SPEAr SoCs
>>   SPEAr : Network driver support added
>>   SPEAr : Network support configured for spear SoCs
>>   SPEAr : macb driver support added for spear310 and spear320
>>   SPEAr : FSMC driver support added
>>   SPEAr : Configuring FSMC driver for NAND interface
>>   SPEAr : i2c driver moved completely into drivers/i2c
>>   SPEAr : smi driver moved completely into drivers/mtd
>>   SPEAr : USBD driver support added
>>   SPEAr : Basic spear1300 architecture support added
>>   SPEAr : spear1300 SoC support added
>>   SPEAr : Supporting various configurations for spear3xx and spear6xx
>>     boards
>>
>>  Makefile                                           |   24 +-
>>  arch/arm/cpu/arm926ejs/spear/Makefile              |    3 +-
>>  arch/arm/cpu/arm926ejs/spear/cpu.c                 |   76 +++
>>  arch/arm/cpu/arm_cortexa8/spear13xx/Makefile       |   52 ++
>>  arch/arm/cpu/arm_cortexa8/spear13xx/cache.S        |  112 ++++
>>  arch/arm/cpu/arm_cortexa8/spear13xx/cpu.c          |   99 ++++
>>  .../arm_cortexa8/spear13xx/reset.c}                |   50 +--
>>  arch/arm/cpu/arm_cortexa8/spear13xx/timer.c        |  136 +++++
>>  arch/arm/include/asm/arch-spear/clk.h              |   27 +
>>  arch/arm/include/asm/arch-spear/hardware.h         |   16 +-
>>  arch/arm/include/asm/arch-spear/spr_misc.h         |    5 +
>>  arch/arm/include/asm/arch-spear13xx/hardware.h     |   40 ++
>>  arch/arm/include/asm/arch-spear13xx/spr_gpt.h      |   85 +++
>>  arch/arm/include/asm/arch-spear13xx/spr_misc.h     |  317 ++++++++++++
>>  arch/arm/include/asm/arch-spear13xx/sys_proto.h    |   32 ++
>>  arch/arm/include/asm/bitops.h                      |   11 +-
>>  board/spear/common/Makefile                        |   10 +-
>>  board/spear/common/spr_misc.c                      |   23 +-
>>  board/spear/spear1300/Makefile                     |   51 ++
>>  board/spear/spear1300/config.mk                    |   28 +
>>  board/spear/spear1300/spear1300.c                  |   86 ++++
>>  .../spear/spear1300/spr_lowlevel_init.S            |   49 +--
>>  board/spear/spear300/config.mk                     |   11 -
>>  board/spear/spear300/spear300.c                    |   10 +-
>>  board/spear/spear310/config.mk                     |   11 -
>>  board/spear/spear310/spear310.c                    |   17 +-
>>  board/spear/spear320/config.mk                     |   11 -
>>  board/spear/spear320/spear320.c                    |   14 +-
>>  board/spear/spear600/config.mk                     |   11 -
>>  board/spear/spear600/spear600.c                    |   10 +-
>>  drivers/i2c/Makefile                               |    2 +-
>>  drivers/i2c/{spr_i2c.c => designware_i2c.c}        |    4 +-
>>  .../spr_i2c.h => drivers/i2c/designware_i2c.h      |    6 +-
>>  drivers/mtd/Makefile                               |    2 +-
>>  drivers/mtd/nand/Makefile                          |    2 +-
>>  drivers/mtd/nand/fsmc_nand.c                       |  365 +++++++++++++
>>  drivers/mtd/nand/spr_nand.c                        |  124 -----
>>  drivers/mtd/{spr_smi.c => st_smi.c}                |   10 +-
>>  .../arch-spear/spr_smi.h => drivers/mtd/st_smi.h   |   10 +-
>>  drivers/net/Makefile                               |    1 +
>>  drivers/net/designware.c                           |  537 ++++++++++++++++++++
>>  drivers/net/designware.h                           |  264 ++++++++++
>>  drivers/serial/usbtty.h                            |    4 +-
>>  drivers/usb/gadget/Makefile                        |    2 +-
>>  drivers/usb/gadget/{spr_udc.c => designware_udc.c} |  116 +++--
>>  include/configs/spear-common.h                     |   27 +-
>>  include/configs/spear13xx.h                        |  199 ++++++++
>>  include/configs/spear3xx.h                         |   30 ++
>>  include/configs/spear6xx.h                         |   13 +
>>  include/linux/mtd/fsmc_nand.h                      |  104 ++++
>>  include/netdev.h                                   |    1 +
>>  include/usb/{spr_udc.h => designware_udc.h}        |    8 +-
>>  52 files changed, 2918 insertions(+), 340 deletions(-)
>>  create mode 100644 arch/arm/cpu/arm926ejs/spear/cpu.c
>>  create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/Makefile
>>  create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/cache.S
>>  create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/cpu.c
>>  copy arch/arm/{include/asm/arch-spear/spr_nand.h => cpu/arm_cortexa8/spear13xx/reset.c} (51%)
>>  mode change 100644 => 100755
>>  create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/timer.c
>>  create mode 100644 arch/arm/include/asm/arch-spear/clk.h
>>  create mode 100644 arch/arm/include/asm/arch-spear13xx/hardware.h
>>  create mode 100644 arch/arm/include/asm/arch-spear13xx/spr_gpt.h
>>  create mode 100644 arch/arm/include/asm/arch-spear13xx/spr_misc.h
>>  create mode 100644 arch/arm/include/asm/arch-spear13xx/sys_proto.h
>>  create mode 100644 board/spear/spear1300/Makefile
>>  create mode 100644 board/spear/spear1300/config.mk
>>  create mode 100644 board/spear/spear1300/spear1300.c
>>  rename arch/arm/include/asm/arch-spear/spr_nand.h => board/spear/spear1300/spr_lowlevel_init.S (50%)
>>  rename drivers/i2c/{spr_i2c.c => designware_i2c.c} (98%)
>>  rename arch/arm/include/asm/arch-spear/spr_i2c.h => drivers/i2c/designware_i2c.h (98%)
>>  create mode 100644 drivers/mtd/nand/fsmc_nand.c
>>  delete mode 100644 drivers/mtd/nand/spr_nand.c
>>  rename drivers/mtd/{spr_smi.c => st_smi.c} (99%)
>>  rename arch/arm/include/asm/arch-spear/spr_smi.h => drivers/mtd/st_smi.h (95%)
>>  create mode 100644 drivers/net/designware.c
>>  create mode 100644 drivers/net/designware.h
>>  rename drivers/usb/gadget/{spr_udc.c => designware_udc.c} (91%)
>>  create mode 100644 include/configs/spear13xx.h
>>  create mode 100644 include/linux/mtd/fsmc_nand.h
>>  rename include/usb/{spr_udc.h => designware_udc.h} (98%)
>>
>>
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
>