From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vipin KUMAR Date: Mon, 03 May 2010 16:47:54 +0530 Subject: [U-Boot] [PATCH v2 16/17] SPEAr : spear1300 SoC support added In-Reply-To: <4BDEA334.7090900@bumblecow.com> References: <1272250610-15439-1-git-send-email-vipin.kumar@st.com> <1272250610-15439-3-git-send-email-vipin.kumar@st.com> <1272250610-15439-4-git-send-email-vipin.kumar@st.com> <1272250610-15439-5-git-send-email-vipin.kumar@st.com> <1272250610-15439-6-git-send-email-vipin.kumar@st.com> <1272250610-15439-7-git-send-email-vipin.kumar@st.com> <1272250610-15439-8-git-send-email-vipin.kumar@st.com> <1272250610-15439-9-git-send-email-vipin.kumar@st.com> <1272250610-15439-10-git-send-email-vipin.kumar@st.com> <1272250610-15439-11-git-send-email-vipin.kumar@st.com> <1272250610-15439-12-git-send-email-vipin.kumar@st.com> <1272250610-15439-13-git-send-email-vipin.kumar@st.com> <1272250610-15439-14-git-send-email-vipin.kumar@st.com> <1272250610-15439-15-git-send-email-vipin.kumar@st.com> <1272250610-15439-16-git-send-email-vipin.kumar@st.com> <1272250610-15439-17-git-send-email-vipin.kumar@st.com> <4BDE1AD0.8070004@bumblecow.com> <4BDE8ADA.3060303@st.com> <4BDEA334.7090900@bumblecow.com > Message-ID: <4BDEB0E2.6010905@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 5/3/2010 3:49 PM, Tom Rix wrote: > Vipin KUMAR wrote: >> On 5/3/2010 6:07 AM, Tom Rix wrote: >>> Vipin KUMAR wrote: >>>> SPEAr1300 SoC support contains basic spear1300 support along with the >>>> usage of following drivers >>>> - serial driver(UART) >>>> - i2c driver >>>> - smi driver >>>> - nand driver(FSMC) >>>> - usbd driver > > > >>>> + >>>> +#define CONFIG_USBD_PRODUCT_NAME "SPEAr SoC" >>>> +#define CONFIG_USBD_MANUFACTURER "ST Microelectronics" >>>> + >>>> +#define CONFIG_EXTRA_ENV_USBTTY "usbtty=cdc_acm\0" >>> Should be conditional on CONFIG_SPEAR_USBTTY >>> Similar changes for spear3xx and spear6xxx >>> >> >> CONFIG_SPEAR_USBTTY is a special case where tty over usb terminal is >> used for downloading and flashing images. >> usbtty environment variable should normally also be set as cdc_acm to >> make sure that we can switch to tty over usb terminal directly from >> uboot prompt by simply running setenv stdout usbtty\; setenv stdin usbtty >> >> So, I am not making it conditional to CONFIG_EXTRA_ENV_USBTTY >> > > What I mean is the extra enviroment variable and config's > are dependent on USBD. It usb is not configured, these are > not needed. > USBD is always configured. That's why this feature may be desirable > Tom > >