From: Vipin KUMAR <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 08/17] SPEAr : Network support configured for spear SoCs
Date: Tue, 04 May 2010 12:45:17 +0530 [thread overview]
Message-ID: <4BDFC985.3070607@st.com> (raw)
In-Reply-To: <4BDE0F6D.5080801@bumblecow.com>
On 5/3/2010 5:19 AM, Tom Rix wrote:
> Vipin KUMAR wrote:
>> Signed-off-by: Vipin Kumar <vipin.kumar@st.com>
>> ---
>> arch/arm/include/asm/arch-spear/hardware.h | 1 +
>> board/spear/spear300/spear300.c | 6 ++++++
>> board/spear/spear310/spear310.c | 6 ++++++
>> board/spear/spear320/spear320.c | 6 ++++++
>> board/spear/spear600/spear600.c | 6 ++++++
>> include/configs/spear-common.h | 10 ++++++++--
>> include/configs/spear3xx.h | 3 +++
>> 7 files changed, 36 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-spear/hardware.h
>> b/arch/arm/include/asm/arch-spear/hardware.h
>> index 818f36c..39d64b6 100644
>> --- a/arch/arm/include/asm/arch-spear/hardware.h
>> +++ b/arch/arm/include/asm/arch-spear/hardware.h
>> @@ -31,6 +31,7 @@
>> #define CONFIG_SPEAR_SYSCNTLBASE (0xFCA00000)
>> #define CONFIG_SPEAR_TIMERBASE (0xFC800000)
>> #define CONFIG_SPEAR_MISCBASE (0xFCA80000)
>> +#define CONFIG_SPEAR_ETHBASE (0xE0800000)
>>
>> #define CONFIG_SYS_NAND_CLE (1 << 16)
>> #define CONFIG_SYS_NAND_ALE (1 << 17)
>> diff --git a/board/spear/spear300/spear300.c
>> b/board/spear/spear300/spear300.c
>> index 60ee544..cd24247 100644
>> --- a/board/spear/spear300/spear300.c
>> +++ b/board/spear/spear300/spear300.c
>> @@ -22,6 +22,7 @@
>> */
>>
>> #include <common.h>
>> +#include <netdev.h>
>> #include <nand.h>
>> #include <asm/io.h>
>> #include <asm/arch/hardware.h>
>> @@ -56,3 +57,8 @@ int board_nand_init(struct nand_chip *nand)
>>
>> return -1;
>> }
>> +
>> +int board_eth_init(bd_t *bis)
>> +{
>> + return designware_initialize(0, CONFIG_SPEAR_ETHBASE);
>> +}
>
> The function can be conditionally compiled in based on
> CONFIG_DESIGNWARE_ETH
>
> board_eth_init may be able to go in the spear/common
>
OK. I would make the CONFIG_DESIGNWARE_ETH change in patch v3
Since the board/spear/common is compiled for all spear SOCs and
the network support is different for every SoC, it makes sense to keep
it in board directory itself
Please see the macb support patch
> Tom
>
>> diff --git a/board/spear/spear310/spear310.c
>> b/board/spear/spear310/spear310.c
>> index 03dfe16..e8a6552 100644
>> --- a/board/spear/spear310/spear310.c
>> +++ b/board/spear/spear310/spear310.c
>> @@ -23,6 +23,7 @@
>> */
>>
>> #include <common.h>
>> +#include <netdev.h>
>> #include <nand.h>
>> #include <asm/io.h>
>> #include <asm/arch/hardware.h>
>> @@ -57,3 +58,8 @@ int board_nand_init(struct nand_chip *nand)
>>
>> return -1;
>> }
>> +
>> +int board_eth_init(bd_t *bis)
>> +{
>> + return dw_mii_initialize(0, CONFIG_SPEAR_ETHBASE);
>> +}
>> diff --git a/board/spear/spear320/spear320.c
>> b/board/spear/spear320/spear320.c
>> index 2ba2dbb..72bc9a5 100644
>> --- a/board/spear/spear320/spear320.c
>> +++ b/board/spear/spear320/spear320.c
>> @@ -23,6 +23,7 @@
>> */
>>
>> #include <common.h>
>> +#include <netdev.h>
>> #include <nand.h>
>> #include <asm/io.h>
>> #include <asm/arch/hardware.h>
>> @@ -57,3 +58,8 @@ int board_nand_init(struct nand_chip *nand)
>>
>> return -1;
>> }
>> +
>> +int board_eth_init(bd_t *bis)
>> +{
>> + return dw_mii_initialize(0, CONFIG_SPEAR_ETHBASE);
>> +}
>> diff --git a/board/spear/spear600/spear600.c
>> b/board/spear/spear600/spear600.c
>> index eef9a37..6d921bd 100644
>> --- a/board/spear/spear600/spear600.c
>> +++ b/board/spear/spear600/spear600.c
>> @@ -22,6 +22,7 @@
>> */
>>
>> #include <common.h>
>> +#include <netdev.h>
>> #include <nand.h>
>> #include <asm/io.h>
>> #include <asm/arch/hardware.h>
>> @@ -51,3 +52,8 @@ int board_nand_init(struct nand_chip *nand)
>>
>> return -1;
>> }
>> +
>> +int board_eth_init(bd_t *bis)
>> +{
>> + return designware_initialize(0, CONFIG_SPEAR_ETHBASE);
>> +}
>> diff --git a/include/configs/spear-common.h
>> b/include/configs/spear-common.h
>> index 68ba293..ecb1fd1 100644
>> --- a/include/configs/spear-common.h
>> +++ b/include/configs/spear-common.h
>> @@ -27,6 +27,11 @@
>> * Common configurations used for both spear3xx as well as spear6xx
>> */
>>
>> +/* Ethernet driver configuration */
>> +#define CONFIG_DESIGNWARE_ETH
>> +#define CONFIG_NET_MULTI
>> +#define CONFIG_PHY_RESET_DELAY (10000) /* in usec */
>> +
>> /* USBD driver configuration */
>> #define CONFIG_SPEARUDC
>> #define CONFIG_USB_DEVICE
>> @@ -98,11 +103,12 @@
>> #define CONFIG_CMD_MEMORY
>> #define CONFIG_CMD_RUN
>> #define CONFIG_CMD_SAVES
>> +#define CONFIG_CMD_NET
>> +#define CONFIG_CMD_PING
>> +#define CONFIG_CMD_DHCP
>>
>> /* This must be included AFTER the definition of CONFIG_COMMANDS (if
>> any) */
>> #include <config_cmd_default.h>
>> -#undef CONFIG_CMD_NET
>> -#undef CONFIG_CMD_NFS
>>
>> /*
>> * Default Environment Varible definitions
>> diff --git a/include/configs/spear3xx.h b/include/configs/spear3xx.h
>> index 0248aba..502c50f 100644
>> --- a/include/configs/spear3xx.h
>> +++ b/include/configs/spear3xx.h
>> @@ -41,6 +41,9 @@
>>
>> #include <configs/spear-common.h>
>>
>> +/* Ethernet driver configuration */
>> +#define CONFIG_DW_ALTDESCRIPTOR 1
>> +
>> /* Serial Configuration (PL011) */
>> #define CONFIG_SYS_SERIAL0 0xD0000000
>>
>
>
next prev parent reply other threads:[~2010-05-04 7:15 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 2:56 [U-Boot] [PATCH v2 00/17] Network support for spear platform and spear1300 support Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 01/17] u-boot.img file not created when srctree and objtree are different Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 02/17] change_bit routine defined Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 03/17] SPEAr : SMI erase and write timeouts increased Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 04/17] SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 05/17] SPEAr : Reducing the max RAM size to 128MB Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 06/17] SPEAr : Basic arch related support added for SPEAr SoCs Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 07/17] SPEAr : Network driver support added Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 08/17] SPEAr : Network support configured for spear SoCs Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 09/17] SPEAr : macb driver support added for spear310 and spear320 Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 10/17] SPEAr : FSMC driver support added Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 11/17] SPEAr : Configuring FSMC driver for NAND interface Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 12/17] SPEAr : i2c driver moved completely into drivers/i2c Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 13/17] SPEAr : smi driver moved completely into drivers/mtd Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 14/17] SPEAr : USBD driver support added Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 15/17] SPEAr : Basic spear1300 architecture " Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 16/17] SPEAr : spear1300 SoC " Vipin KUMAR
2010-04-26 2:56 ` [U-Boot] [PATCH v2 17/17] SPEAr : Supporting various configurations for spear3xx and spear6xx boards Vipin KUMAR
2010-05-03 0:38 ` Tom Rix
2010-05-03 7:59 ` Vipin KUMAR
2010-05-03 0:37 ` [U-Boot] [PATCH v2 16/17] SPEAr : spear1300 SoC support added Tom Rix
2010-05-03 8:35 ` Vipin KUMAR
2010-05-03 10:19 ` Tom Rix
2010-05-03 11:17 ` Vipin KUMAR
2010-05-03 0:33 ` [U-Boot] [PATCH v2 15/17] SPEAr : Basic spear1300 architecture " Tom Rix
2010-05-03 11:14 ` Vipin KUMAR
2010-05-03 0:29 ` [U-Boot] [PATCH v2 14/17] SPEAr : USBD driver " Tom Rix
2010-05-03 0:27 ` [U-Boot] [PATCH v2 13/17] SPEAr : smi driver moved completely into drivers/mtd Tom Rix
2010-04-27 5:08 ` [U-Boot] [PATCH v2 12/17] SPEAr : i2c driver moved completely into drivers/i2c Heiko Schocher
2010-05-03 0:25 ` Tom Rix
2010-05-04 9:07 ` Vipin KUMAR
2010-05-04 17:56 ` Scott Wood
2010-05-06 1:44 ` Vipin KUMAR
2010-05-05 21:37 ` Tom Rix
2010-05-06 2:08 ` Vipin KUMAR
2010-04-27 21:09 ` [U-Boot] [PATCH v2 11/17] SPEAr : Configuring FSMC driver for NAND interface Scott Wood
2010-05-03 0:24 ` Tom Rix
2010-05-04 8:48 ` Vipin KUMAR
2010-04-27 21:09 ` [U-Boot] [PATCH v2 10/17] SPEAr : FSMC driver support added Scott Wood
2010-05-03 0:22 ` Tom Rix
2010-05-04 8:08 ` Vipin KUMAR
2010-05-03 0:14 ` [U-Boot] [PATCH v2 09/17] SPEAr : macb driver support added for spear310 and spear320 Tom Rix
2010-05-04 8:01 ` Vipin KUMAR
2010-05-02 23:49 ` [U-Boot] [PATCH v2 08/17] SPEAr : Network support configured for spear SoCs Tom Rix
2010-05-04 7:15 ` Vipin KUMAR [this message]
2010-05-02 23:48 ` [U-Boot] [PATCH v2 07/17] SPEAr : Network driver support added Tom Rix
2010-05-04 6:33 ` Vipin KUMAR
2010-05-04 13:14 ` Tom Rix
2010-05-02 23:40 ` [U-Boot] [PATCH v2 06/17] SPEAr : Basic arch related support added for SPEAr SoCs Tom Rix
2010-05-04 5:57 ` Vipin KUMAR
2010-05-02 23:37 ` [U-Boot] [PATCH v2 05/17] SPEAr : Reducing the max RAM size to 128MB Tom Rix
2010-05-04 5:50 ` Vipin KUMAR
2010-05-02 23:36 ` [U-Boot] [PATCH v2 04/17] SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET Tom Rix
2010-05-04 5:34 ` Vipin KUMAR
2010-05-04 12:18 ` Tom Rix
2010-05-06 4:11 ` Vipin KUMAR
2010-05-06 22:28 ` Wolfgang Denk
2010-05-02 23:33 ` [U-Boot] [PATCH v2 03/17] SPEAr : SMI erase and write timeouts increased Tom Rix
2010-05-04 3:43 ` Vipin KUMAR
2010-05-02 23:31 ` [U-Boot] [PATCH v2 02/17] change_bit routine defined Tom Rix
2010-05-04 1:54 ` Vipin KUMAR
2010-05-02 23:27 ` [U-Boot] [PATCH v2 01/17] u-boot.img file not created when srctree and objtree are different Tom Rix
2010-04-30 11:08 ` [U-Boot] [PATCH v2 00/17] Network support for spear platform and spear1300 support Vipin KUMAR
2010-04-30 12:48 ` Tom Rix
2010-05-01 10:09 ` Vipin Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BDFC985.3070607@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox