[U-Boot] [PATCH 4/4] Environment in MMC

[Alagu Sankar <alagusankar@embwise.com>]

Stefano Babic wrote:
> Sudhakar Rajashekhara wrote:
>   
>> Hi Alagu,
>>
>>     
> Hi,
>
>   
>> On Wed, May 12, 2010 at 15:08:27, Alagu Sankar wrote:
>>     
>>> This patch is to save environment data to mmc card. It uses interfaces defined
>>> in generic MMC framework.  This is enabled with CONFIG_ENV_IS_IN_MMC option.
>>> Based on the earlier patch from Terry Lv at Freescale
>>>       
>
> Should be not better you send your comments to Terry as to generate a
> new patch? His patch had already passed some reviews and he can
> integrate your comments. I miss here what you changed respect Terry, and
> you miss some comments in the previous reviews, for example regarding
> the usage of the ALIGN macro. Why do you need two patches for the same
> purpose ?
>
>   
>> Why this has been moved up? If there is any genuine reason for this, then
>> you can mention it in patch description.
>>     
>
> That is correct. The mmc must be initialized before env_init to get the
> environment working.
>
> Best regards,
> Stefano Babic
>
>   
When I searched for the Environment support in MMC, I came across 
Terry's earlier patches, but they were not cleanly getting applied to 
the current tree.  There is no value add here except fixing the patch 
errors and generating a new patch for the current tree.  So there is no 
question of adding any copyright here.  Terry has indicated an update to 
his patch already.  I will be resubmitting my other patches with 
reference to Terry's latest patch.

- Alagu Sankar