From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alagu Sankar Date: Fri, 14 May 2010 16:24:29 +0530 Subject: [U-Boot] [PATCH 4/4] Environment in MMC In-Reply-To: <4BED1FB5.8010305@denx.de> References: <1273657107-7148-1-git-send-email-alagusankar@embwise.com> <1273657107-7148-2-git-send-email-alagusankar@embwise.com> <1273657107-7148-3-git-send-email-alagusankar@embwise.com> <1273657107-7148-4-git-send-email-alagusankar@embwise.com> <014f01caf33f$17c731a0$475594e0$@raj@ti.com> <4BED1FB5.8010305@denx.de> Message-ID: <4BED2BE5.70106@embwise.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefano Babic wrote: > Sudhakar Rajashekhara wrote: > >> Hi Alagu, >> >> > Hi, > > >> On Wed, May 12, 2010 at 15:08:27, Alagu Sankar wrote: >> >>> This patch is to save environment data to mmc card. It uses interfaces defined >>> in generic MMC framework. This is enabled with CONFIG_ENV_IS_IN_MMC option. >>> Based on the earlier patch from Terry Lv at Freescale >>> > > Should be not better you send your comments to Terry as to generate a > new patch? His patch had already passed some reviews and he can > integrate your comments. I miss here what you changed respect Terry, and > you miss some comments in the previous reviews, for example regarding > the usage of the ALIGN macro. Why do you need two patches for the same > purpose ? > > >> Why this has been moved up? If there is any genuine reason for this, then >> you can mention it in patch description. >> > > That is correct. The mmc must be initialized before env_init to get the > environment working. > > Best regards, > Stefano Babic > > When I searched for the Environment support in MMC, I came across Terry's earlier patches, but they were not cleanly getting applied to the current tree. There is no value add here except fixing the patch errors and generating a new patch for the current tree. So there is no question of adding any copyright here. Terry has indicated an update to his patch already. I will be resubmitting my other patches with reference to Terry's latest patch. - Alagu Sankar