From: Alagu Sankar <alagusankar@embwise.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] Environment in MMC
Date: Fri, 14 May 2010 17:24:32 +0530 [thread overview]
Message-ID: <4BED39F8.7090402@embwise.com> (raw)
In-Reply-To: <4BED36B0.4010303@denx.de>
Stefano Babic wrote:
> Alagu Sankar wrote:
>
>
>>>
>>>
>> When I searched for the Environment support in MMC, I came across
>> Terry's earlier patches, but they were not cleanly getting applied to
>> the current tree.
>>
>
> I have tried to apply again last Terry's patch, I see only a couple of
> coding-style problems, no errors at all:
>
> Applying: Save environment data to mmc.
> /home/stefano/Projects/imx/u-boot-imx/.git/rebase-apply/patch:21:
> trailing whitespace.
> * Thus It is required that operations like pin multiplexer
> /home/stefano/Projects/imx/u-boot-imx/.git/rebase-apply/patch:54:
> trailing whitespace.
> * Thus It is required that operations like pin multiplexer
> warning: 2 lines add whitespace errors.
>
>
>> There is no value add here except fixing the patch
>> errors and generating a new patch for the current tree.
>>
>
> Probably not needed. I have not seen the errors you reported. Are you
> sure you have tested with Terry's last patch ? It seems you submit an
> earlier version.
>
>
>> So there is no
>> question of adding any copyright here.
>>
>
> Yes, Wolfgang has already answered. No need to add a copyright for small
> patches.
>
> Best regards,
> Stefano Babic
>
>
I was referring to Terry's old patches, and not the v5 patch he has
submitted recently. I started on this some time back. Its a mistake
that I did not check the updates that happened recently, before
submitting the patches.
Best Regards,
Alagu Sankar
next prev parent reply other threads:[~2010-05-14 11:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 9:38 [U-Boot] [PATCH 1/4] SD1.00 wide-bus fix Alagu Sankar
2010-05-12 9:38 ` [U-Boot] [PATCH 2/4] MMC Card Capacity Bug Fix Alagu Sankar
2010-05-12 9:38 ` [U-Boot] [PATCH 3/4] MMC Multi-block Support Alagu Sankar
2010-05-12 9:38 ` [U-Boot] [PATCH 4/4] Environment in MMC Alagu Sankar
2010-05-13 7:08 ` Lv Terry-R65388
2010-05-14 8:26 ` Sudhakar Rajashekhara
2010-05-14 9:52 ` Wolfgang Denk
2010-05-14 10:02 ` Stefano Babic
2010-05-14 10:54 ` Alagu Sankar
2010-05-14 11:40 ` Stefano Babic
2010-05-14 11:54 ` Alagu Sankar [this message]
2010-05-17 7:31 ` Lv Terry-R65388
2010-05-14 17:37 ` [U-Boot] [PATCH 3/4] MMC Multi-block Support Andy Fleming
2010-09-13 7:51 ` Lei Wen
2010-10-04 20:32 ` John Rigby
2010-10-14 21:44 ` Steve Sakoman
2010-10-14 21:53 ` Paulraj, Sandeep
2010-10-23 15:14 ` Ghorai, Sukumar
2010-10-25 17:29 ` Steve Sakoman
2010-10-25 18:19 ` Ghorai, Sukumar
2010-05-14 8:16 ` [U-Boot] [PATCH 2/4] MMC Card Capacity Bug Fix Sudhakar Rajashekhara
2010-05-14 17:32 ` Andy Fleming
2010-05-13 15:13 ` [U-Boot] [PATCH 1/4] SD1.00 wide-bus fix Paulraj, Sandeep
2010-05-14 17:30 ` Andy Fleming
2010-09-09 22:21 ` John Rigby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BED39F8.7090402@embwise.com \
--to=alagusankar@embwise.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox