public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr	clocks to speed.c
Date: Fri, 21 May 2010 13:11:50 -0500	[thread overview]
Message-ID: <4BF6CCE6.1080109@freescale.com> (raw)
In-Reply-To: <1274465254-9002-1-git-send-email-timur@freescale.com>

On 05/21/2010 01:07 PM, Timur Tabi wrote:
> On most Freescale 85xx boards, the CONFIG_SYS_CLK_FREQ and CONFIG_DDR_CLK_FREQ
> macros are defined like this:

Like what?

> This means that in order to use these macros, the callers must have prototypes
> for the corresponding functions.  On 85xx, only speed.c uses these macros, so
> let's define the prototypes there.  This eliminates the need to define the
> prototypes in the board config files.

It also eliminates the utility of the prototype in making sure usage 
matches the definition, and requires that the user of the macros provide 
implementation prerequisites.

-Scott

  reply	other threads:[~2010-05-21 18:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 18:07 [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c Timur Tabi
2010-05-21 18:11 ` Scott Wood [this message]
2010-05-21 18:18   ` Timur Tabi
2010-05-21 18:34     ` Scott Wood
2010-05-21 18:36       ` Timur Tabi
2010-05-21 18:40         ` Timur Tabi
2010-05-21 18:44         ` Scott Wood
2010-05-21 18:44       ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF6CCE6.1080109@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox