From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c
Date: Fri, 21 May 2010 13:36:47 -0500 [thread overview]
Message-ID: <4BF6D2BF.20709@freescale.com> (raw)
In-Reply-To: <4BF6D21A.5090502@freescale.com>
Scott Wood wrote:
>> Doh. Git commit delete those lines because they began with a "#".
>
> Hmm... is there any way to override that and insert such a line into a
> git commit?
I was going to just insert a blank space or some other character before the #.
> I think the board header file (or some header factored out from a set of
> similar boards, which the board header includes) is exactly where it
> belongs, given that it's implemented in a board C file, and the C call
> is not a public API.
Well, you'll have to convince Wolfgang of that, not me. He won't accept my
P1022DS board patch until I fix this "problem".
> Some boards just hard code it as a constant.
> Others might want to call some other function, maybe with arguments (in
> fact, I see a dummy argument of zero passed in many if not all existing
> calls to these functions -- why?).
Probably some legacy stuff. Once this issue is resolved, I'll probably post
a patch that unifies the functions in some way.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-05-21 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 18:07 [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c Timur Tabi
2010-05-21 18:11 ` Scott Wood
2010-05-21 18:18 ` Timur Tabi
2010-05-21 18:34 ` Scott Wood
2010-05-21 18:36 ` Timur Tabi [this message]
2010-05-21 18:40 ` Timur Tabi
2010-05-21 18:44 ` Scott Wood
2010-05-21 18:44 ` Peter Tyser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF6D2BF.20709@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox