public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr	clocks to speed.c
Date: Fri, 21 May 2010 13:44:24 -0500	[thread overview]
Message-ID: <4BF6D488.2030303@freescale.com> (raw)
In-Reply-To: <4BF6D2BF.20709@freescale.com>

On 05/21/2010 01:36 PM, Timur Tabi wrote:
> Scott Wood wrote:
>
>>> Doh.  Git commit delete those lines because they began with a "#".
>>
>> Hmm... is there any way to override that and insert such a line into a
>> git commit?
>
> I was going to just insert a blank space or some other character before the #.
>
>> I think the board header file (or some header factored out from a set of
>> similar boards, which the board header includes) is exactly where it
>> belongs, given that it's implemented in a board C file, and the C call
>> is not a public API.
>
> Well, you'll have to convince Wolfgang of that, not me.  He won't accept my
> P1022DS board patch until I fix this "problem".

I think the "some header factored out from a set of similar boards" (or 
possibly similar board support idioms) approach would meet his request, 
though doing that at too fine-grained a level could lead to an 
unreadable tangle of header files and/or ifdefs.

-Scott

  parent reply	other threads:[~2010-05-21 18:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-21 18:07 [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and ddr clocks to speed.c Timur Tabi
2010-05-21 18:11 ` Scott Wood
2010-05-21 18:18   ` Timur Tabi
2010-05-21 18:34     ` Scott Wood
2010-05-21 18:36       ` Timur Tabi
2010-05-21 18:40         ` Timur Tabi
2010-05-21 18:44         ` Scott Wood [this message]
2010-05-21 18:44       ` Peter Tyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF6D488.2030303@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox