From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Fri, 21 May 2010 13:44:24 -0500
Subject: [U-Boot] [PATCH] mpc85xx: add function prototypes for sys and
 ddr	clocks to speed.c
In-Reply-To: <4BF6D2BF.20709@freescale.com>
References: <1274465254-9002-1-git-send-email-timur@freescale.com>
	<4BF6CCE6.1080109@freescale.com> <4BF6CE65.5060307@freescale.com>
	<4BF6D21A.5090502@freescale.com> <4BF6D2BF.20709@freescale.com>
Message-ID: <4BF6D488.2030303@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/21/2010 01:36 PM, Timur Tabi wrote:
> Scott Wood wrote:
>
>>> Doh.  Git commit delete those lines because they began with a "#".
>>
>> Hmm... is there any way to override that and insert such a line into a
>> git commit?
>
> I was going to just insert a blank space or some other character before the #.
>
>> I think the board header file (or some header factored out from a set of
>> similar boards, which the board header includes) is exactly where it
>> belongs, given that it's implemented in a board C file, and the C call
>> is not a public API.
>
> Well, you'll have to convince Wolfgang of that, not me.  He won't accept my
> P1022DS board patch until I fix this "problem".

I think the "some header factored out from a set of similar boards" (or 
possibly similar board support idioms) approach would meet his request, 
though doing that at too fine-grained a level could lead to an 
unreadable tangle of header files and/or ifdefs.

-Scott