From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library
Date: Fri, 21 May 2010 15:28:00 -0500 [thread overview]
Message-ID: <4BF6ECD0.4060202@freescale.com> (raw)
In-Reply-To: <20100521201643.7E4FACCF026@gemini.denx.de>
Wolfgang Denk wrote:
> 799.992 MHz seems to be 24 * 33,333,000 Hz. Are you sure this is the
> exact quartz frequency on your board? If yes, then the number printed
> should probably remain 799.992 MHz. Or is it 33,333,333 Hz? Or
> 33,000,000 ?
Ok, I see your point. Technically, I am returning a less precise number.
However, the current code adds a 1 to the result, which is definitely wrong.
On my board, for example, it returns 99999001, which is not correct. So
the existing "rounding" algorithm is broken.
However, I believe that displaying 799.999 MHz instead of 800 MHz is silly.
The problem is that strmhz() rounds to the nearest KHz. I wonder if that's
really useful. Perhaps we should make it act more like print_size(), where
it prints KHz, MHz, or GHz as appropriate, and rounds to the nearest 10th,
instead of 1000th.
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2010-05-21 20:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 9:18 [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library Kumar Gala
2010-05-21 9:18 ` [U-Boot] [PATCH] ppc/85xx: Convert MPC8572DS to using board common ICS307 code Kumar Gala
2010-05-21 9:18 ` [U-Boot] [PATCH] ppc/85xx: Convert MPC8536DS " Kumar Gala
2010-05-21 15:57 ` [U-Boot] [PATCH] Move ICS CLK chip frequenty calculation code into a common board library Timur Tabi
2010-05-21 22:19 ` Kumar Gala
2010-05-21 22:29 ` Wolfgang Denk
2010-05-21 22:22 ` Kumar Gala
2010-05-21 22:35 ` Wolfgang Denk
2010-05-21 18:42 ` Timur Tabi
2010-05-22 22:41 ` Kumar Gala
2010-05-21 18:59 ` Timur Tabi
2010-05-21 19:35 ` Timur Tabi
2010-05-21 19:52 ` Wolfgang Denk
2010-05-21 19:58 ` Timur Tabi
2010-05-21 20:16 ` Wolfgang Denk
2010-05-21 20:28 ` Timur Tabi [this message]
2010-05-21 21:03 ` Wolfgang Denk
2010-05-21 21:09 ` Timur Tabi
2010-05-22 22:39 ` Kumar Gala
2010-05-22 22:36 ` [U-Boot] [PATCH v2] " Kumar Gala
2010-05-24 14:52 ` Timur Tabi
2010-05-24 18:57 ` Kumar Gala
2010-05-24 19:06 ` Timur Tabi
2010-05-24 20:09 ` [U-Boot] [PATCH v3] " Kumar Gala
2010-05-24 20:12 ` Timur Tabi
2010-06-30 9:52 ` Kumar Gala
2010-07-14 19:33 ` Wolfgang Denk
2010-07-14 21:21 ` [U-Boot] [PATCH v4] Move ICS CLK chip frequency " Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF6ECD0.4060202@freescale.com \
--to=timur@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox