From: Shiraz HASHIM <shiraz.hashim@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 00/19] SPEAr : Network support for spear platforms and SPEAr1300
Date: Tue, 25 May 2010 16:33:41 +0530 [thread overview]
Message-ID: <4BFBAE8D.3060703@st.com> (raw)
In-Reply-To: <4BFBA619.1060109@st.com>
Hello,
On 5/25/2010 3:57 PM, Shiraz Hashim wrote:
> Hello Vipin,
>
> On 5/6/2010 4:48 PM, Vipin KUMAR wrote:
>> Hello Tom,
>> The following patch-set contains all the accepted feedbacks on patch-set v2.
>> Please consider this for submission into mainline
>>
>> Below changes are introduced other than the recieved review comments
>> 1. Introduced a CONFIG_DW_SEARCH_PHY definition, which if defined searches
>> the ethernet phy address. Searching was always enabled in earlier patch
>> 2. Introduced a new function dw_write_hwaddr in ethernet driver and
>> registered it as a callback via dev->write_hwaddr. This is a new feature
>> recently implemented by Ben.
>>
>> Thanks in advance
>>
>> Regards
>> Vipin
>>
>> Vipin Kumar (19):
>> u-boot.img file not created when srctree and objtree are different
>> change_bit routine defined
>> SPEAr : SMI erase and write timeouts increased
>> SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET
>> SPEAr : Reducing the max RAM size to 128MB
>> SPEAr : Basic arch related support added for SPEAr SoCs
>> SPEAr : Network driver support added
>> SPEAr : Network support configured for spear SoCs
>> SPEAr : macb driver support added for spear310 and spear320
>> SPEAr : FSMC driver support added
>> SPEAr : Configuring FSMC driver for NAND interface
>> SPEAr : i2c driver moved completely into drivers/i2c
>> SPEAr : smi driver moved completely into drivers/mtd
>> SPEAr : USB Device Controller driver support added
>> SPEAr : Supporting various configurations for spear3xx and spear6xx
>> boards
>> SPEAr : Basic spear1300 architecture support added
>> SPEAr : spear1300 SoC support added
>> SPEAr : Removing extraneous code
>> SPEAr : USB device controller bugfixes
>>
>> MAINTAINERS | 1 +
>> MAKEALL | 1 +
>> Makefile | 30 +-
>> arch/arm/cpu/arm926ejs/spear/Makefile | 3 +-
>> arch/arm/cpu/arm926ejs/spear/cpu.c | 78 +++
>> arch/arm/cpu/arm_cortexa8/spear13xx/Makefile | 52 ++
>> arch/arm/cpu/arm_cortexa8/spear13xx/cache.S | 114 +++++
>> arch/arm/cpu/arm_cortexa8/spear13xx/cpu.c | 96 ++++
>> .../arm_cortexa8/spear13xx/reset.c} | 52 +--
>> arch/arm/cpu/arm_cortexa8/spear13xx/timer.c | 138 +++++
>> .../arm/include/asm/arch-spear/clk.h | 26 +-
>> arch/arm/include/asm/arch-spear/hardware.h | 16 +-
>> arch/arm/include/asm/arch-spear/spr_misc.h | 5 +
>> .../arm/include/asm/arch-spear13xx/hardware.h | 33 +-
>> arch/arm/include/asm/arch-spear13xx/spr_gpt.h | 85 ++++
>> arch/arm/include/asm/arch-spear13xx/spr_misc.h | 317 ++++++++++++
>> .../arm/include/asm/arch-spear13xx/sys_proto.h | 29 +-
>> arch/arm/include/asm/bitops.h | 11 +-
>> board/spear/common/Makefile | 10 +-
>> board/spear/common/spr_misc.c | 28 +-
>> board/spear/spear1300/Makefile | 51 ++
>> board/spear/spear1300/config.mk | 28 +
>> board/spear/spear1300/spear1300.c | 88 ++++
>> .../spear/spear1300/spr_lowlevel_init.S | 35 +-
>> board/spear/spear300/config.mk | 11 -
>> board/spear/spear300/spear300.c | 15 +-
>> board/spear/spear310/config.mk | 11 -
>> board/spear/spear310/spear310.c | 36 ++-
>> board/spear/spear320/config.mk | 11 -
>> board/spear/spear320/spear320.c | 23 +-
>> board/spear/spear600/config.mk | 11 -
>> board/spear/spear600/spear600.c | 15 +-
>> doc/README.designware_eth | 25 +
>> doc/README.spear | 46 ++-
>> drivers/i2c/Makefile | 2 +-
>> drivers/i2c/{spr_i2c.c => designware_i2c.c} | 4 +-
>> .../spr_i2c.h => drivers/i2c/designware_i2c.h | 6 +-
>> drivers/mtd/Makefile | 2 +-
>> drivers/mtd/nand/Makefile | 2 +-
>> drivers/mtd/nand/fsmc_nand.c | 366 ++++++++++++++
>> drivers/mtd/nand/spr_nand.c | 124 -----
>> drivers/mtd/{spr_smi.c => st_smi.c} | 59 ++-
>> .../arch-spear/spr_smi.h => drivers/mtd/st_smi.h | 8 +-
>> drivers/net/Makefile | 1 +
>> drivers/net/designware.c | 531 ++++++++++++++++++++
>> drivers/net/designware.h | 264 ++++++++++
>> drivers/serial/usbtty.h | 4 +-
>> drivers/usb/gadget/Makefile | 2 +-
>> drivers/usb/gadget/{spr_udc.c => designware_udc.c} | 116 +++--
>> include/configs/spear-common.h | 33 +-
>> include/configs/spear13xx_evb.h | 202 ++++++++
>> include/configs/{spear3xx.h => spear3xx_evb.h} | 30 ++
>> include/configs/{spear6xx.h => spear6xx_evb.h} | 13 +
>> include/linux/mtd/fsmc_nand.h | 104 ++++
>> include/netdev.h | 1 +
>> include/usb/{spr_udc.h => designware_udc.h} | 6 +-
>> 56 files changed, 2993 insertions(+), 418 deletions(-)
>> create mode 100644 arch/arm/cpu/arm926ejs/spear/cpu.c
>> create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/Makefile
>> create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/cache.S
>> create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/cpu.c
>> rename arch/arm/{include/asm/arch-spear/spr_nand.h => cpu/arm_cortexa8/spear13xx/reset.c} (50%)
>> mode change 100644 => 100755
>> create mode 100644 arch/arm/cpu/arm_cortexa8/spear13xx/timer.c
>> copy include/configs/spear6xx.h => arch/arm/include/asm/arch-spear/clk.h (64%)
>> copy include/configs/spear6xx.h => arch/arm/include/asm/arch-spear13xx/hardware.h (58%)
>> create mode 100644 arch/arm/include/asm/arch-spear13xx/spr_gpt.h
>> create mode 100644 arch/arm/include/asm/arch-spear13xx/spr_misc.h
>> copy include/configs/spear6xx.h => arch/arm/include/asm/arch-spear13xx/sys_proto.h (64%)
>> create mode 100644 board/spear/spear1300/Makefile
>> create mode 100644 board/spear/spear1300/config.mk
>> create mode 100644 board/spear/spear1300/spear1300.c
>> copy include/configs/spear6xx.h => board/spear/spear1300/spr_lowlevel_init.S (56%)
>> create mode 100644 doc/README.designware_eth
>> rename drivers/i2c/{spr_i2c.c => designware_i2c.c} (98%)
>> rename arch/arm/include/asm/arch-spear/spr_i2c.h => drivers/i2c/designware_i2c.h (98%)
>> create mode 100644 drivers/mtd/nand/fsmc_nand.c
>> delete mode 100644 drivers/mtd/nand/spr_nand.c
>> rename drivers/mtd/{spr_smi.c => st_smi.c} (94%)
>> rename arch/arm/include/asm/arch-spear/spr_smi.h => drivers/mtd/st_smi.h (96%)
>> create mode 100644 drivers/net/designware.c
>> create mode 100644 drivers/net/designware.h
>> rename drivers/usb/gadget/{spr_udc.c => designware_udc.c} (91%)
>> create mode 100644 include/configs/spear13xx_evb.h
>> rename include/configs/{spear3xx.h => spear3xx_evb.h} (85%)
>> rename include/configs/{spear6xx.h => spear6xx_evb.h} (82%)
>> create mode 100644 include/linux/mtd/fsmc_nand.h
>> rename include/usb/{spr_udc.h => designware_udc.h} (98%)
>
> Fix following checkpatch warning in your next incremental patch.
> I would continue with applying this patchset over rebased bri/uboot/next to
> bri/uboot/upstream.
>
> WARNING: unnecessary whitespace before a quoted newline
> #106: FILE: board/spear/common/spr_misc.c:210:
> puts("I2C EEPROM writing failed \n");
>
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> #900: FILE: drivers/mtd/nand/fsmc_nand.c:26:
> +#include <asm/io.h>
>
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> #1478: FILE: drivers/net/designware.c:32:
> +#include <asm/io.h>
>
> WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
> #1627: FILE: drivers/net/designware.c:181:
> +static int dw_eth_send(struct eth_device *dev, volatile void *packet,
>
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> #4188: FILE: board/spear/spear1300/spear1300.c:27:
> +#include <asm/io.h>
>
> WARNING: please, no space before tabs
> #5186: FILE: arch/arm/include/asm/arch-spear13xx/spr_gpt.h:43:
> +#define GPT_PRESCALER_2 ^I^I0x0001$
>
> WARNING: please, no space before tabs
> #5187: FILE: arch/arm/include/asm/arch-spear13xx/spr_gpt.h:44:
> +#define GPT_PRESCALER_4 ^I^I0x0002$
>
> WARNING: please, no space before tabs
> #5188: FILE: arch/arm/include/asm/arch-spear13xx/spr_gpt.h:45:
> +#define GPT_PRESCALER_8 ^I^I0x0003$
>
> total: 0 errors, 8 warnings, 4126 lines checked
>
> /home/shiraz/patches/vipin_u-boot_v3_over_upstream has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
Please ignore this mail as it was meant for our internal repository :)
regards
Shiraz
prev parent reply other threads:[~2010-05-25 11:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 11:18 [U-Boot] [PATCH v3 00/19] SPEAr : Network support for spear platforms and SPEAr1300 Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 01/19] u-boot.img file not created when srctree and objtree are different Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 02/19] change_bit routine defined Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 03/19] SPEAr : SMI erase and write timeouts increased Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 04/19] SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 05/19] SPEAr : Reducing the max RAM size to 128MB Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 06/19] SPEAr : Basic arch related support added for SPEAr SoCs Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 07/19] SPEAr : Network driver support added Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 08/19] SPEAr : Network support configured for spear SoCs Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 09/19] SPEAr : macb driver support added for spear310 and spear320 Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 10/19] SPEAr : FSMC driver support added Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 11/19] SPEAr : Configuring FSMC driver for NAND interface Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 12/19] SPEAr : i2c driver moved completely into drivers/i2c Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 13/19] SPEAr : smi driver moved completely into drivers/mtd Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 14/19] SPEAr : USB Device Controller driver support added Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 15/19] SPEAr : Supporting various configurations for spear3xx and spear6xx boards Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 16/19] SPEAr : Basic spear1300 architecture support added Vipin KUMAR
2010-05-06 11:18 ` [U-Boot] [PATCH v3 17/19] SPEAr : spear1300 SoC " Vipin KUMAR
2010-05-06 11:19 ` [U-Boot] [PATCH v3 18/19] SPEAr : Removing extraneous code Vipin KUMAR
2010-05-06 11:19 ` [U-Boot] [PATCH v3 19/19] SPEAr : USB device controller bugfixes Vipin KUMAR
2010-05-14 8:44 ` Remy Bohmer
2010-05-14 8:43 ` [U-Boot] [PATCH v3 14/19] SPEAr : USB Device Controller driver support added Remy Bohmer
2010-05-10 20:20 ` [U-Boot] [PATCH v3 08/19] SPEAr : Network support configured for spear SoCs Ben Warren
2010-05-09 14:16 ` [U-Boot] [PATCH v3 00/19] SPEAr : Network support for spear platforms and SPEAr1300 Vipin Kumar
2010-05-14 2:56 ` Vipin KUMAR
2010-05-28 16:52 ` Vipin Kumar
2010-05-28 20:31 ` Ben Warren
2010-06-03 11:55 ` Vipin KUMAR
2010-06-11 6:14 ` Vipin KUMAR
2010-06-14 8:12 ` Vipin KUMAR
2010-06-22 14:23 ` Vipin Kumar
2010-06-22 15:30 ` [U-Boot] SPEAr (ARM) patchset inclusion for u-boot Armando VISCONTI
2010-06-22 20:30 ` Wolfgang Denk
2010-06-22 20:45 ` Armando VISCONTI
2010-06-23 3:31 ` Vipin KUMAR
2010-06-25 17:53 ` Armando VISCONTI
2010-05-25 10:27 ` [U-Boot] [PATCH v3 00/19] SPEAr : Network support for spear platforms and SPEAr1300 Shiraz HASHIM
2010-05-25 11:03 ` Shiraz HASHIM [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFBAE8D.3060703@st.com \
--to=shiraz.hashim@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox