[U-Boot] [PATCH v2] misc: add gpio based status led driver

Wolfgang Denk
2010-04-24T22:32:45Z

Dear Thomas Chou,

In message <4BD36BAE.2060903@wytron.com.tw> you wrote:
>
> >> This patch adds a status led driver followed the GPIO access
> >> conventions of Linux. The led mask is used to specify the gpio pin.
> >>
> >> Signed-off-by: Thomas Chou<thomas@wytron.com.tw>
> >> ---
> >> Moved to drivers/misc.
> >>
> > Which boards are the users of this code?
...

> It is used in the example designs of Altera NEEK and DE2 boards, which I
> provided for nios2 linux/uclinux on nios wiki. They are used by many
> nios2 users.
>
> It may be used by other boards which support the GPIO access conventions
> of Linux. Though the GPIO access is not unified in u-boot currently, I
> think it should be the right direction to follow the conventions of Linux.

I mean, which board in U-Boot uses this code? I didn't find any.

The convention is not to add unused code. If there are no real users
for this, the patch should be delayed until a board gets added that
actually uses it.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You are an excellent tactician, Captain. You let your second in com-
mand attack while you sit and watch for weakness.
-- Khan Noonian Singh, "Space Seed", stardate 3141.9