From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board
Date: Wed, 26 May 2010 14:04:58 -0500 [thread overview]
Message-ID: <4BFD70DA.9040908@freescale.com> (raw)
In-Reply-To: <4BFD662C.9020503@freescale.com>
On 05/26/2010 01:19 PM, Timur Tabi wrote:
> Scott Wood wrote:
>
>> Perhaps (most of) this information could be put in a data structure to
>> which you point?
>
> That doesn't change the amount of information that needs to be passed, it
> only makes the prototype have fewer lines.
Which is relevant, given that you're whipping out a big scary-looking
prototype as a reason to avoid refactoring. :-)
>
> The point I'm trying to make is that the code in question is not the same
> code copy/pasted three times. Every line is different. Moving that code
> into a function is not going to simplify anything.
They are not identical lines, but they're doing the same basic thing --
making it data driven would be a proper separation of concerns.
-Scott
next prev parent reply other threads:[~2010-05-26 19:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 22:01 [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board Timur Tabi
2010-05-20 22:33 ` Wolfgang Denk
2010-05-20 23:13 ` Kumar Gala
2010-05-21 6:50 ` Wolfgang Denk
2010-05-20 23:23 ` Timur Tabi
2010-05-21 7:07 ` Wolfgang Denk
2010-05-21 13:45 ` Timur Tabi
2010-05-21 14:22 ` Wolfgang Denk
2010-05-21 14:33 ` Timur Tabi
2010-05-21 16:07 ` Timur Tabi
2010-05-26 18:12 ` Timur Tabi
2010-05-26 18:17 ` Scott Wood
2010-05-26 18:19 ` Timur Tabi
2010-05-26 19:04 ` Scott Wood [this message]
2010-05-26 19:34 ` Timur Tabi
2010-05-26 19:46 ` Scott Wood
2010-05-26 21:59 ` Timur Tabi
2010-05-25 18:30 ` Timur Tabi
2010-05-26 20:10 ` Wolfgang Denk
2010-05-26 20:18 ` Timur Tabi
2010-05-26 20:24 ` Timur Tabi
2010-05-27 7:02 ` Wolfgang Denk
2010-05-27 14:31 ` Timur Tabi
2010-05-27 18:11 ` Wolfgang Denk
2010-05-27 18:25 ` Timur Tabi
2010-05-27 19:03 ` Scott Wood
2010-05-27 19:07 ` Timur Tabi
2010-05-27 19:10 ` Scott Wood
2010-05-27 19:54 ` Wolfgang Denk
2010-05-27 19:53 ` Wolfgang Denk
2010-05-27 20:11 ` Timur Tabi
2010-05-27 21:10 ` Wolfgang Denk
2010-05-27 19:53 ` Wolfgang Denk
2010-05-27 20:03 ` Timur Tabi
2010-05-27 20:59 ` Wolfgang Denk
2010-05-27 20:05 ` Scott Wood
2010-05-27 21:03 ` Wolfgang Denk
2010-05-27 19:45 ` Wolfgang Denk
2010-05-27 19:54 ` Timur Tabi
2010-05-27 20:00 ` Wolfgang Denk
2010-05-27 20:10 ` Scott Wood
2010-05-21 0:26 ` [U-Boot] [PATCH] powerpc: add support for the FreescaleP1022DS " Liu Dave-R63238
2010-05-21 15:25 ` Timur Tabi
2010-05-21 9:46 ` [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS " Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFD70DA.9040908@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox