From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Wed, 26 May 2010 14:04:58 -0500 Subject: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board In-Reply-To: <4BFD662C.9020503@freescale.com> References: <1274392909-16422-1-git-send-email-timur@freescale.com> <20100520223324.50594CCF026@gemini.denx.de> <20100521070719.5B27BCCF026@gemini.denx.de> <4BFD6479.9040408@freescale.com> <4BFD65C0.7020106@freescale.com> <4BFD662C.9020503@freescale.com> Message-ID: <4BFD70DA.9040908@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 05/26/2010 01:19 PM, Timur Tabi wrote: > Scott Wood wrote: > >> Perhaps (most of) this information could be put in a data structure to >> which you point? > > That doesn't change the amount of information that needs to be passed, it > only makes the prototype have fewer lines. Which is relevant, given that you're whipping out a big scary-looking prototype as a reason to avoid refactoring. :-) > > The point I'm trying to make is that the code in question is not the same > code copy/pasted three times. Every line is different. Moving that code > into a function is not going to simplify anything. They are not identical lines, but they're doing the same basic thing -- making it data driven would be a proper separation of concerns. -Scott