public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] dm9000x.c: fix compile problems
@ 2010-05-26 20:21 Wolfgang Denk
  2010-05-26 21:39 ` Andreas Bießmann
  2010-05-26 21:44 ` Ben Warren
  0 siblings, 2 replies; 4+ messages in thread
From: Wolfgang Denk @ 2010-05-26 20:21 UTC (permalink / raw)
  To: u-boot

Use readX() / writeX() accessors instead of inX() / outX().

Suggested-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 drivers/net/dm9000x.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
index f121286..137e41f 100644
--- a/drivers/net/dm9000x.c
+++ b/drivers/net/dm9000x.c
@@ -117,12 +117,12 @@ static void DM9000_iow(int reg, u8 value);
 
 /* DM9000 network board routine ---------------------------- */
 
-#define DM9000_outb(d,r) outb(d, r)
-#define DM9000_outw(d,r) outw(d, r)
-#define DM9000_outl(d,r) outl(d, r)
-#define DM9000_inb(r) inb(r)
-#define DM9000_inw(r) inw(r)
-#define DM9000_inl(r) inl(r)
+#define DM9000_outb(d,r) writeb(d, r)
+#define DM9000_outw(d,r) writew(d, r)
+#define DM9000_outl(d,r) writel(d, r)
+#define DM9000_inb(r) readb(r)
+#define DM9000_inw(r) readw(r)
+#define DM9000_inl(r) readl(r)
 
 #ifdef CONFIG_DM9000_DEBUG
 static void
-- 
1.6.6.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] dm9000x.c: fix compile problems
  2010-05-26 20:21 [U-Boot] [PATCH] dm9000x.c: fix compile problems Wolfgang Denk
@ 2010-05-26 21:39 ` Andreas Bießmann
  2010-05-26 21:44 ` Ben Warren
  1 sibling, 0 replies; 4+ messages in thread
From: Andreas Bießmann @ 2010-05-26 21:39 UTC (permalink / raw)
  To: u-boot

Dear Wolfgang,

Am 26.05.2010 um 22:21 schrieb Wolfgang Denk:

> Use readX() / writeX() accessors instead of inX() / outX().

this works for me.

> Suggested-by: Mike Frysinger <vapier@gentoo.org>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
Tested-by: Andreas Bie?mann <biessmann@corscience.de>

regards

Andreas Bie?mann

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] dm9000x.c: fix compile problems
  2010-05-26 20:21 [U-Boot] [PATCH] dm9000x.c: fix compile problems Wolfgang Denk
  2010-05-26 21:39 ` Andreas Bießmann
@ 2010-05-26 21:44 ` Ben Warren
  2010-05-26 22:19   ` Wolfgang Denk
  1 sibling, 1 reply; 4+ messages in thread
From: Ben Warren @ 2010-05-26 21:44 UTC (permalink / raw)
  To: u-boot

Hi Wolfgang,

On 5/26/2010 1:21 PM, Wolfgang Denk wrote:
> Use readX() / writeX() accessors instead of inX() / outX().
>
> Suggested-by: Mike Frysinger<vapier@gentoo.org>
> Signed-off-by: Wolfgang Denk<wd@denx.de>
> ---
>   drivers/net/dm9000x.c |   12 ++++++------
>   1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
> index f121286..137e41f 100644
> --- a/drivers/net/dm9000x.c
> +++ b/drivers/net/dm9000x.c
> @@ -117,12 +117,12 @@ static void DM9000_iow(int reg, u8 value);
>
>   /* DM9000 network board routine ---------------------------- */
>
> -#define DM9000_outb(d,r) outb(d, r)
> -#define DM9000_outw(d,r) outw(d, r)
> -#define DM9000_outl(d,r) outl(d, r)
> -#define DM9000_inb(r) inb(r)
> -#define DM9000_inw(r) inw(r)
> -#define DM9000_inl(r) inl(r)
> +#define DM9000_outb(d,r) writeb(d, r)
> +#define DM9000_outw(d,r) writew(d, r)
> +#define DM9000_outl(d,r) writel(d, r)
> +#define DM9000_inb(r) readb(r)
> +#define DM9000_inw(r) readw(r)
> +#define DM9000_inl(r) readl(r)
>
>   #ifdef CONFIG_DM9000_DEBUG
>   static void
>    
Looks good to me.  Please apply directly.

regards,
Ben

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] dm9000x.c: fix compile problems
  2010-05-26 21:44 ` Ben Warren
@ 2010-05-26 22:19   ` Wolfgang Denk
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2010-05-26 22:19 UTC (permalink / raw)
  To: u-boot

Dear Ben Warren,

In message <4BFD9623.3070708@gmail.com> you wrote:
> 
> Looks good to me.  Please apply directly.

Done, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
       There is enough for the need of everyone in this world,
       but not for the greed of everyone.     - Mahatma Gandhi

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-05-26 22:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 20:21 [U-Boot] [PATCH] dm9000x.c: fix compile problems Wolfgang Denk
2010-05-26 21:39 ` Andreas Bießmann
2010-05-26 21:44 ` Ben Warren
2010-05-26 22:19   ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox