From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] libfdt: introduce function fdt_get_max_phandle
Date: Wed, 26 May 2010 22:38:51 -0400 [thread overview]
Message-ID: <4BFDDB3B.4050605@gmail.com> (raw)
In-Reply-To: <20100526201736.07107EAC238@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Timur Tabi,
>
> In message <1274308618-2974-1-git-send-email-timur@freescale.com> you wrote:
>> Introduce function fdt_get_max_phandle(), which returns the largest value
>> of all phandles in a device tree. This is useful for allocating a new phandle
>> property, since all phandles must be unique.
>>
>> Signed-off-by: Timur Tabi <timur@freescale.com>
>> ---
>> include/libfdt.h | 20 ++++++++++++++++++++
>> lib/libfdt/fdt_ro.c | 17 +++++++++++++++++
>> 2 files changed, 37 insertions(+), 0 deletions(-)
>
> Please submit as part of a patch / patch series that acrtually uses
> this feature. As is, it's just dead code that has no users.
I'm happy with this in principle, and will <ack> formally when the
community is OK with the code change. It looks like a positive
improvement to me, reducing complexity and addressing Timur/Freescale's
needs. Anyway, I envision <acking> the patch and having FSL include it
in whatever MPC8xxx patchset that actually needs the changes.
Thanks and best regards,
gvb
[snip improvement suggestion]
next prev parent reply other threads:[~2010-05-27 2:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 22:36 [U-Boot] [PATCH] libfdt: introduce function fdt_get_max_phandle Timur Tabi
2010-05-26 20:17 ` Wolfgang Denk
2010-05-27 2:38 ` Jerry Van Baren [this message]
2010-07-10 13:27 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFDDB3B.4050605@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox