From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Wed, 26 May 2010 22:38:51 -0400 Subject: [U-Boot] [PATCH] libfdt: introduce function fdt_get_max_phandle In-Reply-To: <20100526201736.07107EAC238@gemini.denx.de> References: <1274308618-2974-1-git-send-email-timur@freescale.com> <20100526201736.07107EAC238@gemini.denx.de> Message-ID: <4BFDDB3B.4050605@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: > Dear Timur Tabi, > > In message <1274308618-2974-1-git-send-email-timur@freescale.com> you wrote: >> Introduce function fdt_get_max_phandle(), which returns the largest value >> of all phandles in a device tree. This is useful for allocating a new phandle >> property, since all phandles must be unique. >> >> Signed-off-by: Timur Tabi >> --- >> include/libfdt.h | 20 ++++++++++++++++++++ >> lib/libfdt/fdt_ro.c | 17 +++++++++++++++++ >> 2 files changed, 37 insertions(+), 0 deletions(-) > > Please submit as part of a patch / patch series that acrtually uses > this feature. As is, it's just dead code that has no users. I'm happy with this in principle, and will formally when the community is OK with the code change. It looks like a positive improvement to me, reducing complexity and addressing Timur/Freescale's needs. Anyway, I envision the patch and having FSL include it in whatever MPC8xxx patchset that actually needs the changes. Thanks and best regards, gvb [snip improvement suggestion]