From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Thu, 27 May 2010 09:31:22 -0500 Subject: [U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board In-Reply-To: <20100527070235.E8812EAC238@gemini.denx.de> References: <1274392909-16422-1-git-send-email-timur@freescale.com> <20100520223324.50594CCF026@gemini.denx.de> <4BFC1736.5030902@freescale.com> <20100526201014.97886EAC238@gemini.denx.de> <4BFD837D.2040508@freescale.com> <20100527070235.E8812EAC238@gemini.denx.de> Message-ID: <4BFE823A.1080409@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk wrote: >> I've looked at get_ram_size(), and I don't think I can use it. > > Then fix it, please. Let me guess, you won't accept my patch until I fix get_ram_size() first and use it, right? >> We use phys_addr_t to represent DDR sizes, which is a 64-bit integer on the >> P1022DS. get_ram_size() takes a 'long' and returns a 'long', so it's not >> capable of handling the amount of memory that we support on the board. >> >> I can use get_ram_size() to test the lower 2GB of DDR, but I can't use it to >> verify the amount of RAM in the system. > > Do you really have > 4 GB RAM on this board? Actually, anything more than 2GB would cause the problem, since the maximum value of a long is 2GB. On this particular board, there is only 2GB, but all of our new boards are expected to support more than 4GB of RAM. > If this turns out to be a real problem, we have to fix get_ram_size to > handle bigger memory sizes as well. I guess this will needed for more > and more systems. Yes. -- Timur Tabi Linux kernel developer at Freescale