[U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

Wolfgang Denk
2010-05-27T07:02:35Z

Dear Timur Tabi,

In message <4BFD837D.2040508@freescale.com> you wrote:
> Wolfgang Denk wrote:
> > It appears you really haven't bothered checking. We have been using
> > it on PowerPC since day 1 - for well over 10 years by now. On many,
> > many systems. Get a clue!
>
> I've looked at get_ram_size(), and I don't think I can use it.

Then fix it, please.

> We use phys_addr_t to represent DDR sizes, which is a 64-bit integer on the
> P1022DS. get_ram_size() takes a 'long' and returns a 'long', so it's not
> capable of handling the amount of memory that we support on the board.
>
> I can use get_ram_size() to test the lower 2GB of DDR, but I can't use it to
> verify the amount of RAM in the system.

Do you really have > 4 GB RAM on this board?

If this turns out to be a real problem, we have to fix get_ram_size to
handle bigger memory sizes as well. I guess this will needed for more
and more systems.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If something is different, it's either better or worse, and usually
both. - Larry Wall