[U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

Wolfgang Denk
2010-05-27T20:59:34Z

Dear Timur Tabi,

In message <4BFED01F.1040703@freescale.com> you wrote:
>
> > Such configurations are usually set up of from several differently
> > sized banks of memory, and get_ram_size() is always run per bank. So
> > as long as chip manufacturers continue to make RAM chips with
> > power-of-two sizes only, everything should be fine.
>
> What if the board has two DIMM slots, one of which has a 1GB DIMM and the
> other has a 512MB DIMM?

Then you run get_ram_size() twice, and it will find 1 GiB and 512 MiB
of memory - what's the problem?

> I thought get_ram_size() was supposed to safely determine how much RAM is
> actually in the system? Otherwise, it should be called verify_ram_size().

Indeed it is intended to determine tha actual RAM size - and does so
fine in dozens of board configurations.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Why waste negative entropy on comments, when you could use the same
entropy to create bugs instead?" - Steve Elias