[U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

Scott Wood
2010-05-26T19:04:58Z

On 05/26/2010 01:19 PM, Timur Tabi wrote:
> Scott Wood wrote:
>
>> Perhaps (most of) this information could be put in a data structure to
>> which you point?
>
> That doesn't change the amount of information that needs to be passed, it
> only makes the prototype have fewer lines.

Which is relevant, given that you're whipping out a big scary-looking
prototype as a reason to avoid refactoring. :-)

>
> The point I'm trying to make is that the code in question is not the same
> code copy/pasted three times. Every line is different. Moving that code
> into a function is not going to simplify anything.

They are not identical lines, but they're doing the same basic thing --
making it data driven would be a proper separation of concerns.

-Scott