[U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

Wolfgang Denk
2010-05-26T20:10:14Z

Dear Timur Tabi,

In message <4BFC1736.5030902@freescale.com> you wrote:
>
> >> + { 0, 333, 1, 5, 31, 3, 0},
> >> + {334, 400, 1, 5, 31, 3, 0},
> >> + {401, 549, 1, 5, 31, 3, 0},
> >> + {550, 680, 1, 5, 31, 5, 0},
> >> + {681, 850, 1, 5, 31, 5, 0},
> >> + { 0, 333, 2, 5, 31, 3, 0},
> >> + {334, 400, 2, 5, 31, 3, 0},
> >> + {401, 549, 2, 5, 31, 3, 0},
> >> + {550, 680, 2, 5, 31, 5, 0},
> >> + {681, 850, 2, 5, 31, 5, 0},
> >
> > Please use TABs for vertical alignment.
>
> Ok, I understand now what you mean. However, the columns are
> right-justified. You can't use tabs to align right-justified columns.

There is exactly two entries in that table where it would make any
difference, and if that's really that important to you, adding two
spaces after the TAB would work wonders.

> > How about using get_ram_size() for autosizing / testing?
>
> It appears get_ram_size() has never been used on PowerPC before. This

It appears you really haven't bothered checking. We have been using
it on PowerPC since day 1 - for well over 10 years by now. On many,
many systems. Get a clue!

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Making files is easy under the UNIX operating system. Therefore,
users tend to create numerous files using large amounts of file
space. It has been said that the only standard thing about all UNIX
systems is the message-of-the-day telling users to clean up their
files. -- System V.2 administrator's guide