[U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

Wolfgang Denk
2010-05-27T18:11:18Z

Dear Timur Tabi,

In message <4BFE823A.1080409@freescale.com> you wrote:
>
> >> I've looked at get_ram_size(), and I don't think I can use it.
> >
> > Then fix it, please.
>
> Let me guess, you won't accept my patch until I fix get_ram_size() first and
> use it, right?

Do you think this is an unreasonable request? A quick fix takes me
less than it takes to write this email (see following patch).

> > Do you really have > 4 GB RAM on this board?
>
> Actually, anything more than 2GB would cause the problem, since the maximum
> value of a long is 2GB. On this particular board, there is only 2GB, but
> all of our new boards are expected to support more than 4GB of RAM.

All the more reasons to fix this.

> > If this turns out to be a real problem, we have to fix get_ram_size to
> > handle bigger memory sizes as well. I guess this will needed for more
> > and more systems.
>
> Yes.

Well, didn't you say you were looking for a list of task to imrpove
U-Boot for your boards?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gods don't like people not doing much work. People who aren't busy
all the time might start to _think_. - Terry Pratchett, _Small Gods_