[U-Boot] [PATCH] powerpc: add support for the Freescale P1022DS reference board

Timur Tabi
2010-05-26T20:18:50Z

Wolfgang Denk wrote:

> There is exactly two entries in that table where it would make any
> difference, and if that's really that important to you, adding two
> spaces after the TAB would work wonders.

The column headers would be unaligned:

static const board_specific_parameters_t bsp[] = {
/*
* memory controller 0
* lo| hi| num| clk| cpo|wrdata|2T
* mhz| mhz|ranks|adjst| | delay|
*/
{ 0, 333, 1, 5, 31, 3, 0},
{334, 400, 1, 5, 31, 3, 0},
{401, 549, 1, 5, 31, 3, 0},
{550, 680, 1, 5, 31, 5, 0},
{681, 850, 1, 5, 31, 5, 0},
{ 0, 333, 2, 5, 31, 3, 0},
{334, 400, 2, 5, 31, 3, 0},
{401, 549, 2, 5, 31, 3, 0},
{550, 680, 2, 5, 31, 5, 0},
{681, 850, 2, 5, 31, 5, 0},
};

>>> How about using get_ram_size() for autosizing / testing?
>>
>> It appears get_ram_size() has never been used on PowerPC before. This
>
> It appears you really haven't bothered checking. We have been using
> it on PowerPC since day 1 - for well over 10 years by now. On many,
> many systems. Get a clue!

Sorry, I must have used grep wrong or something. I see what you're talking
about now.

--
Timur Tabi
Linux kernel developer at Freescale