From: Tom Rix <tom@bumblecow.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: add initilisation of watchdog in init_sequence
Date: Sun, 30 May 2010 06:17:10 -0500 [thread overview]
Message-ID: <4C024936.6090403@bumblecow.com> (raw)
In-Reply-To: <1274872060-24593-1-git-send-email-nicolas.ferre@atmel.com>
Nicolas Ferre wrote:
> For platforms that implement a hardware watchdog, call its initialization
> routine in init_sequence.
> This location has been chosen to be the closest to initialization of console as
> some watchdog drivers are writing status messages. On the other hand, watchdog
> setup should be close to chip startup to be able to begin the triggering
> quickly.
>
I am not opposed to putting watchdog into the init sequence.
A current ARM way for initializing the watchdog is to do it in
s_init. Why doesn't this work for you ?
Reviewing other watchdog additions in the init sequences from powerpc,sh,m68k
If an init is to be added, this setup should be cut-n-pasted from one
of these. There should be follow-on patches to convert the ARM s_init's over to
using the init sequence.
Tom
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> arch/arm/lib/board.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index f5660a9..569009e 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -70,6 +70,10 @@ extern int AT91F_DataflashInit(void);
> extern void dataflash_print_info(void);
> #endif
>
> +#ifdef CONFIG_HW_WATCHDOG
> +extern void hw_watchdog_init(void);
> +#endif
> +
> #ifndef CONFIG_IDENT_STRING
> #define CONFIG_IDENT_STRING ""
> #endif
> @@ -251,6 +255,9 @@ init_fnc_t *init_sequence[] = {
> serial_init, /* serial communications setup */
> console_init_f, /* stage 1 init of console */
> display_banner, /* say that we are here */
> +#if defined(CONFIG_HW_WATCHDOG)
> + hw_watchdog_init, /* watchdog setup */
> +#endif
> #if defined(CONFIG_DISPLAY_CPUINFO)
> print_cpuinfo, /* display cpu info (and speed) */
> #endif
next prev parent reply other threads:[~2010-05-30 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 11:07 [U-Boot] [PATCH] arm: add initilisation of watchdog in init_sequence Nicolas Ferre
2010-05-30 11:17 ` Tom Rix [this message]
2010-06-10 13:47 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C024936.6090403@bumblecow.com \
--to=tom@bumblecow.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox