From: Tom Rix <tom@bumblecow.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4] Support for board Calao USB A9263
Date: Mon, 07 Jun 2010 07:40:06 -0500 [thread overview]
Message-ID: <4C0CE8A6.8080608@bumblecow.com> (raw)
In-Reply-To: <1275494674-11743-1-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas Petazzoni wrote:
> Hello,
>
> This patchset implements the support for the Calao USB A9263 board
> (patch 4). The first three patches are preliminary work, to convert
> the Atmel Dataflash SPI driver to the new C struct accessors
> introduced a few months ago for AT91 support in U-Boot.
>
> Thanks,
This is only a mechanical review.
I tested this patch using MAKEALL arm
and by running the kernel's checkpatch.pl against these patches
There are many at91 errors
Here is a sample, about 10 boards are broken in the same way.
atmel_dataflash_spi.c: In function 'AT91F_SpiInit':
atmel_dataflash_spi.c:42: error: 'AT91_SPI0_BASE' undeclared (first use in this
function)
atmel_dataflash_spi.c:42: error: (Each undeclared identifier is reported only once
atmel_dataflash_spi.c:42: error: for each function it appears in.)
atmel_dataflash_spi.c: In function 'AT91F_SpiEnable':
atmel_dataflash_spi.c:100: error: 'AT91_SPI0_BASE' undeclared (first use in
this function)
atmel_dataflash_spi.c: In function 'AT91F_SpiWrite':
atmel_dataflash_spi.c:138: error: 'AT91_SPI0_BASE' undeclared (first use in
this function)
make[1]: *** [.../build/drivers/spi/atmel_dataflash_spi.o] Error 1
make: *** [.../build/drivers/spi/libspi.a] Error 2
make: *** Waiting for unfinished jobs....
usb9263 does not build
usb9263.ERR
did not build.
Many kernel check patch errors and warnings.
Please resolve these and resubmit.
Tom
next prev parent reply other threads:[~2010-06-07 12:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 16:04 [U-Boot] [PATCH 0/4] Support for board Calao USB A9263 Thomas Petazzoni
2010-06-02 16:04 ` [U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors Thomas Petazzoni
2010-06-02 16:04 ` [U-Boot] [PATCH 2/4] at91_spi: remove register offsets Thomas Petazzoni
2010-06-02 16:04 ` [U-Boot] [PATCH 3/4] at91sam9263: add new style definition for SPI0_BASE Thomas Petazzoni
2010-06-02 16:04 ` [U-Boot] [PATCH 4/4] Support for Calao USB A9263 board based on AT91SAM9263 CPU Thomas Petazzoni
2010-06-07 12:40 ` Tom Rix [this message]
2010-06-07 21:56 ` [U-Boot] [PATCH 0/4] Calao USB-A9263 v2 Thomas Petazzoni
2010-06-07 21:56 ` [U-Boot] [PATCH 1/4] Atmel Dataflash: convert to C struct accessors Thomas Petazzoni
2010-06-07 22:52 ` Mike Frysinger
2010-06-08 12:24 ` Thomas Petazzoni
2010-06-08 19:20 ` Mike Frysinger
2010-06-09 7:06 ` Thomas Petazzoni
2010-06-09 21:33 ` Mike Frysinger
2010-06-07 21:56 ` [U-Boot] [PATCH 2/4] at91_spi: remove register offsets Thomas Petazzoni
2010-06-07 21:56 ` [U-Boot] [PATCH 3/4] Add new style definition for SPI0_BASE Thomas Petazzoni
2010-06-07 21:56 ` [U-Boot] [PATCH 4/4] Support for Calao USB A9263 board based on AT91SAM9263 CPU Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0CE8A6.8080608@bumblecow.com \
--to=tom@bumblecow.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox