From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom Rix <tom@bumblecow.com>
Date: Mon, 07 Jun 2010 07:40:06 -0500
Subject: [U-Boot] [PATCH 0/4] Support for board Calao USB A9263
In-Reply-To: <1275494674-11743-1-git-send-email-thomas.petazzoni@free-electrons.com>
References: <1275494674-11743-1-git-send-email-thomas.petazzoni@free-electrons.com>
Message-ID: <4C0CE8A6.8080608@bumblecow.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Thomas Petazzoni wrote:
> Hello,
> 
> This patchset implements the support for the Calao USB A9263 board
> (patch 4). The first three patches are preliminary work, to convert
> the Atmel Dataflash SPI driver to the new C struct accessors
> introduced a few months ago for AT91 support in U-Boot.
> 
> Thanks,

This is only a mechanical review.
I tested this patch using MAKEALL arm
and by running the kernel's checkpatch.pl against these patches

There are many at91 errors
Here is a sample, about 10 boards are broken in the same way.

	atmel_dataflash_spi.c: In function 'AT91F_SpiInit':
	atmel_dataflash_spi.c:42: error: 'AT91_SPI0_BASE' undeclared (first use in this 
function)
	atmel_dataflash_spi.c:42: error: (Each undeclared identifier is reported only once
	atmel_dataflash_spi.c:42: error: for each function it appears in.)
	atmel_dataflash_spi.c: In function 'AT91F_SpiEnable':
	atmel_dataflash_spi.c:100: error: 'AT91_SPI0_BASE' undeclared (first use in 
this function)
	atmel_dataflash_spi.c: In function 'AT91F_SpiWrite':
	atmel_dataflash_spi.c:138: error: 'AT91_SPI0_BASE' undeclared (first use in 
this function)
	make[1]: *** [.../build/drivers/spi/atmel_dataflash_spi.o] Error 1
	make: *** [.../build/drivers/spi/libspi.a] Error 2
	make: *** Waiting for unfinished jobs....

usb9263 does not build

usb9263.ERR
did not build.

Many kernel check patch errors and warnings.

Please resolve these and resubmit.

Tom