From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: warn about spaces in device names
Date: Sun, 20 Jun 2010 23:05:32 -0700 [thread overview]
Message-ID: <4C1F012C.5000000@gmail.com> (raw)
In-Reply-To: <1276135848-7711-1-git-send-email-vapier@gentoo.org>
Hi Mike,
On 6/9/2010 7:10 PM, Mike Frysinger wrote:
> Some commands operate on eth device names (like 'mii'), but those cannot
> be passed on the command line as one argument. So detect devices like
> these and warn about them so someone will fix it.
>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> net/eth.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/net/eth.c b/net/eth.c
> index b650a20..40e66e5 100644
> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -225,6 +225,9 @@ int eth_initialize(bd_t *bis)
> puts (" [PRIME]");
> }
>
> + if (strchr(dev->name, ' '))
> + puts("\nWarning: eth device name has a space!\n");
> +
> eth_getenv_enetaddr_by_index(eth_number, env_enetaddr);
>
> if (memcmp(env_enetaddr, "\0\0\0\0\0\0", 6)) {
>
Applied to net/next.
regards,
Ben
prev parent reply other threads:[~2010-06-21 6:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 2:10 [U-Boot] [PATCH] net: warn about spaces in device names Mike Frysinger
2010-06-21 6:05 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1F012C.5000000@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox