From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] uli526x: drop newlines from device name
Date: Sun, 20 Jun 2010 23:06:04 -0700 [thread overview]
Message-ID: <4C1F014C.3000208@gmail.com> (raw)
In-Reply-To: <1276136061-7807-1-git-send-email-vapier@gentoo.org>
Hi Mike,
On 6/9/2010 7:14 PM, Mike Frysinger wrote:
> Device names should not contain non-printable characters like newlines.
>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> drivers/net/uli526x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/uli526x.c b/drivers/net/uli526x.c
> index 9477851..56eee7b 100644
> --- a/drivers/net/uli526x.c
> +++ b/drivers/net/uli526x.c
> @@ -225,7 +225,7 @@ int uli526x_initialize(bd_t *bis)
> iobase&= ~0xf;
>
> dev = (struct eth_device *)malloc(sizeof *dev);
> - sprintf(dev->name, "uli526x#%d\n", card_number);
> + sprintf(dev->name, "uli526x#%d", card_number);
> db = (struct uli526x_board_info *)
> malloc(sizeof(struct uli526x_board_info));
>
>
Applied to net/next.
regards,
Ben
prev parent reply other threads:[~2010-06-21 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 2:14 [U-Boot] [PATCH] uli526x: drop newlines from device name Mike Frysinger
2010-06-21 6:06 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1F014C.3000208@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox