* [U-Boot] [PATCH] uli526x: drop newlines from device name
@ 2010-06-10 2:14 Mike Frysinger
2010-06-21 6:06 ` Ben Warren
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-06-10 2:14 UTC (permalink / raw)
To: u-boot
Device names should not contain non-printable characters like newlines.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
drivers/net/uli526x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/uli526x.c b/drivers/net/uli526x.c
index 9477851..56eee7b 100644
--- a/drivers/net/uli526x.c
+++ b/drivers/net/uli526x.c
@@ -225,7 +225,7 @@ int uli526x_initialize(bd_t *bis)
iobase &= ~0xf;
dev = (struct eth_device *)malloc(sizeof *dev);
- sprintf(dev->name, "uli526x#%d\n", card_number);
+ sprintf(dev->name, "uli526x#%d", card_number);
db = (struct uli526x_board_info *)
malloc(sizeof(struct uli526x_board_info));
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] uli526x: drop newlines from device name
2010-06-10 2:14 [U-Boot] [PATCH] uli526x: drop newlines from device name Mike Frysinger
@ 2010-06-21 6:06 ` Ben Warren
0 siblings, 0 replies; 2+ messages in thread
From: Ben Warren @ 2010-06-21 6:06 UTC (permalink / raw)
To: u-boot
Hi Mike,
On 6/9/2010 7:14 PM, Mike Frysinger wrote:
> Device names should not contain non-printable characters like newlines.
>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> drivers/net/uli526x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/uli526x.c b/drivers/net/uli526x.c
> index 9477851..56eee7b 100644
> --- a/drivers/net/uli526x.c
> +++ b/drivers/net/uli526x.c
> @@ -225,7 +225,7 @@ int uli526x_initialize(bd_t *bis)
> iobase&= ~0xf;
>
> dev = (struct eth_device *)malloc(sizeof *dev);
> - sprintf(dev->name, "uli526x#%d\n", card_number);
> + sprintf(dev->name, "uli526x#%d", card_number);
> db = (struct uli526x_board_info *)
> malloc(sizeof(struct uli526x_board_info));
>
>
Applied to net/next.
regards,
Ben
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-21 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-10 2:14 [U-Boot] [PATCH] uli526x: drop newlines from device name Mike Frysinger
2010-06-21 6:06 ` Ben Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox