From: "Eric Bénard" <eric@eukrea.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] at91_emac: Write MAC address automatically
Date: Mon, 21 Jun 2010 09:50:08 +0200 [thread overview]
Message-ID: <4C1F19B0.6080208@eukrea.com> (raw)
In-Reply-To: <4C1EFFBF.6030902@gmail.com>
Hi Ben,
Le 21/06/2010 07:59, Ben Warren a ?crit :
> On 6/15/2010 5:36 AM, Eric B?nard wrote:
>> +
>> + if (netdev->enetaddr != 0) {
>>
> This check's not necessary. The caller checks if the MAC address is
> valid ( a more extensive check than you do here)
OK, fixed patch sent, thanks.
Eric
prev parent reply other threads:[~2010-06-21 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 12:36 [U-Boot] [PATCH 2/2] at91_emac: Write MAC address automatically Eric Bénard
2010-06-21 5:59 ` Ben Warren
2010-06-21 7:41 ` [U-Boot] [PATCH v2] " Eric Bénard
2010-06-21 17:57 ` Ben Warren
2010-06-21 7:50 ` Eric Bénard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1F19B0.6080208@eukrea.com \
--to=eric@eukrea.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox