[U-Boot] [PATCH] smc911x_eeprom

[U-Boot] [PATCH] smc911x_eeprom

[Sergey Alyoshin]

smc911x_eeprom: smc911x_detect_chip() function return 0 on success

diff --git a/examples/standalone/smc911x_eeprom.c
b/examples/standalone/smc911x_eeprom.c
index 104047f..cb3c131 100644
--- a/examples/standalone/smc911x_eeprom.c
+++ b/examples/standalone/smc911x_eeprom.c
@@ -240,7 +240,7 @@ static void dump_eeprom(struct eth_device *dev)
 static int smc911x_init(struct eth_device *dev)
 {
 	/* See if there is anything there */
-	if (!smc911x_detect_chip(dev))
+	if (smc911x_detect_chip(dev))
 		return 1;

 	smc911x_reset(dev);

[U-Boot] [PATCH] smc911x_eeprom

[Ben Warren]

Hi Sergey,

On 6/29/2010 7:59 AM, Sergey Alyoshin wrote:
> smc911x_eeprom: smc911x_detect_chip() function return 0 on success
>
> diff --git a/examples/standalone/smc911x_eeprom.c
> b/examples/standalone/smc911x_eeprom.c
> index 104047f..cb3c131 100644
> --- a/examples/standalone/smc911x_eeprom.c
> +++ b/examples/standalone/smc911x_eeprom.c
> @@ -240,7 +240,7 @@ static void dump_eeprom(struct eth_device *dev)
>   static int smc911x_init(struct eth_device *dev)
>   {
>   	/* See if there is anything there */
> -	if (!smc911x_detect_chip(dev))
> +	if (smc911x_detect_chip(dev))
>   		return 1;
>
>   	smc911x_reset(dev);
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>    
Somebody beat you to it.  See commit 
88fd3dbe7dac275bc2ae7727c7ebd293c53780c0 in net/next.

regards,
Ben

[U-Boot] [PATCH] smc911x_eeprom

[Mike Frysinger]

On Tuesday, June 29, 2010 10:59:02 Sergey Alyoshin wrote:
> smc911x_eeprom: smc911x_detect_chip() function return 0 on success

this should be the subject, not the changelog

> 
> diff --git a/examples/standalone/smc911x_eeprom.c

you're missing a signed-off-by tag which means your patch cannot be accepted

this ignores the fact that someone has already sent in a patch for this issue 
and that has been added ;)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100629/da08116f/attachment.pgp 

[U-Boot] [PATCH] smc911x_eeprom

[Sergey Alyoshin]

Ok, ok, I get it.


On 6/29/10, Mike Frysinger <vapier@gentoo.org> wrote:
> On Tuesday, June 29, 2010 10:59:02 Sergey Alyoshin wrote:
>> smc911x_eeprom: smc911x_detect_chip() function return 0 on success
>
> this should be the subject, not the changelog
>
>>
>> diff --git a/examples/standalone/smc911x_eeprom.c
>
> you're missing a signed-off-by tag which means your patch cannot be accepted
>
> this ignores the fact that someone has already sent in a patch for this
> issue
> and that has been added ;)
> -mike
>