From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_ide: Convert to [read,write][b,w]
Date: Thu, 01 Jul 2010 02:44:01 +0200 [thread overview]
Message-ID: <4C2BE4D1.8090506@free.fr> (raw)
In-Reply-To: <201007010209.32414.marek.vasut@gmail.com>
Le 01/07/2010 02:09, Marek Vasut a ?crit :
>>>> common/cmd_ide.c | 22 +++++++++++++---------
>>>> 1 files changed, 13 insertions(+), 9 deletions(-)
>>>
>>> I don't see the big advantage of this patch yet.
>>
>> It won't compile at least on ARM. Same case as with the dm9000 ethernet
>> adapter.
>>> What are the exact advantages of your version?
>>
>> That it actually compiles and works on other architectures than ppc.
> Any updates ?
Actually I've compiled cmd_ide.c for ARM -- I just sent a patchset for
this. Required me to #define __io in my board's config, and also to
#define CONFIG_IDE_SWAP_IO, a new configuration option which replaces
the complex conditionals on __PPC__ et al.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-07-01 0:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 19:18 [U-Boot] [PATCH] cmd_ide: Convert to [read,write][b,w] Marek Vasut
2010-06-23 20:51 ` Wolfgang Denk
2010-06-24 0:36 ` Marek Vasut
2010-07-01 0:09 ` Marek Vasut
2010-07-01 0:44 ` Albert ARIBAUD [this message]
2010-07-01 3:33 ` Marek Vasut
2010-07-21 14:42 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2BE4D1.8090506@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox