From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 01 Jul 2010 02:44:01 +0200 Subject: [U-Boot] [PATCH] cmd_ide: Convert to [read,write][b,w] In-Reply-To: <201007010209.32414.marek.vasut@gmail.com> References: <1277320683-2057-1-git-send-email-marek.vasut@gmail.com> <20100623205128.52C001524F4@gemini.denx.de> <201006240236.00745.marek.vasut@gmail.com> <201007010209.32414.marek.vasut@gmail.com> Message-ID: <4C2BE4D1.8090506@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 01/07/2010 02:09, Marek Vasut a ?crit : >>>> common/cmd_ide.c | 22 +++++++++++++--------- >>>> 1 files changed, 13 insertions(+), 9 deletions(-) >>> >>> I don't see the big advantage of this patch yet. >> >> It won't compile at least on ARM. Same case as with the dm9000 ethernet >> adapter. >>> What are the exact advantages of your version? >> >> That it actually compiles and works on other architectures than ppc. > Any updates ? Actually I've compiled cmd_ide.c for ARM -- I just sent a patchset for this. Required me to #define __io in my board's config, and also to #define CONFIG_IDE_SWAP_IO, a new configuration option which replaces the complex conditionals on __PPC__ et al. Amicalement, -- Albert.