From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 05 Jul 2010 13:41:36 +0200 Subject: [U-Boot] [PATCH 3/4] egiga: remove references to kirkwood SoC In-Reply-To: References: <1278089603-901-1-git-send-email-albert.aribaud@free.fr> <1278089603-901-2-git-send-email-albert.aribaud@free.fr> <1278089603-901-3-git-send-email-albert.aribaud@free.fr> <1278089603-901-4-git-send-email-albert.aribaud@free.fr> Message-ID: <4C31C4F0.6070104@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 05/07/2010 13:02, Prafulla Wadaskar a ?crit : >> -----Original Message----- >> From: u-boot-bounces at lists.denx.de >> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Albert Aribaud >> Sent: Friday, July 02, 2010 10:23 PM >> To: u-boot at lists.denx.de >> Subject: [U-Boot] [PATCH 3/4] egiga: remove references to kirkwood SoC >> >> Macros, types, variables, functions in egiga >> refer to kirkwood even though they are not >> kirkwood-specific. Rename them, across the >> whole source tree when necessary. > > NAK, as commented for Patch 1/4 > you can address it more like splitting a driver into generic and specific interfaces > and then adding new support I'm not sure I get your meaning here. Do you suggest I submit not four but only two patches, one with all egiga-out-of-kirkwood changes and one with orion5x support? Or is is something else entirely? > Regards.. > Prafulla .. Amicalement, -- Albert.