From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Usage of bi_env ?
Date: Wed, 07 Jul 2010 17:07:00 +0200 [thread overview]
Message-ID: <4C349814.2000804@googlemail.com> (raw)
With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives:
...
env_t = 0x00000000
...
The code in common/cmd_bdinfo.c for this is
bd_t *bd = gd->bd;
...
print_num ("env_t", (ulong)bd->bi_env);
While checking if 0 for this value is correct or not, it looks to me
that bi_env isn't set anywhere and is unused [1]. And it looks like
bi_env is printed only in the ARM version of bdinfo. Do I miss
anything here?
Best regards
Dirk
[1] grep for bi_env in 2010.03:
./include/asm-i386/u-boot.h:54: struct environment_s *bi_env;
./include/asm-i386/u-boot.h:62:#define bi_env_data bi_env->data
./include/asm-i386/u-boot.h:63:#define bi_env_crc bi_env->crc
./include/asm-arm/u-boot.h:42: struct environment_s *bi_env;
./include/asm-arm/u-boot.h:52:#define bi_env_data bi_env->data
./include/asm-arm/u-boot.h:53:#define bi_env_crc bi_env->crc
./include/asm-mips/u-boot.h:45:#define bi_env_data bi_env->data
./include/asm-mips/u-boot.h:46:#define bi_env_crc bi_env->crc
./include/asm-avr32/u-boot.h:29: struct environment_s *bi_env;
./common/cmd_bdinfo.c:328: print_num ("env_t", (ulong)bd->bi_env);
next reply other threads:[~2010-07-07 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 15:07 Dirk Behme [this message]
2010-07-15 21:21 ` [U-Boot] Usage of bi_env ? Wolfgang Denk
2010-07-27 16:38 ` Dirk Behme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C349814.2000804@googlemail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox