From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Wed, 07 Jul 2010 17:07:00 +0200 Subject: [U-Boot] Usage of bi_env ? Message-ID: <4C349814.2000804@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de With U-Boot 2010.03 on an ARM board, the output of 'bdinfo' command gives: ... env_t = 0x00000000 ... The code in common/cmd_bdinfo.c for this is bd_t *bd = gd->bd; ... print_num ("env_t", (ulong)bd->bi_env); While checking if 0 for this value is correct or not, it looks to me that bi_env isn't set anywhere and is unused [1]. And it looks like bi_env is printed only in the ARM version of bdinfo. Do I miss anything here? Best regards Dirk [1] grep for bi_env in 2010.03: ./include/asm-i386/u-boot.h:54: struct environment_s *bi_env; ./include/asm-i386/u-boot.h:62:#define bi_env_data bi_env->data ./include/asm-i386/u-boot.h:63:#define bi_env_crc bi_env->crc ./include/asm-arm/u-boot.h:42: struct environment_s *bi_env; ./include/asm-arm/u-boot.h:52:#define bi_env_data bi_env->data ./include/asm-arm/u-boot.h:53:#define bi_env_crc bi_env->crc ./include/asm-mips/u-boot.h:45:#define bi_env_data bi_env->data ./include/asm-mips/u-boot.h:46:#define bi_env_crc bi_env->crc ./include/asm-avr32/u-boot.h:29: struct environment_s *bi_env; ./common/cmd_bdinfo.c:328: print_num ("env_t", (ulong)bd->bi_env);