From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 08 Jul 2010 08:11:04 +0200 Subject: [U-Boot] [PATCH V2 3/3] edmini: add IDE support In-Reply-To: References: <1278431949-11593-1-git-send-email-albert.aribaud@free.fr> <1278431949-11593-2-git-send-email-albert.aribaud@free.fr> <1278431949-11593-3-git-send-email-albert.aribaud@free.fr> <4C345BE4.9060809@free.fr> <4C348A63.2030407@free.fr> Message-ID: <4C356BF8.7030502@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Le 08/07/2010 08:01, Prafulla Wadaskar a ?crit : > > >> -----Original Message----- >> From: Albert ARIBAUD [mailto:albert.aribaud at free.fr] >> Sent: Wednesday, July 07, 2010 7:39 PM >> To: Prafulla Wadaskar >> Cc: u-boot at lists.denx.de >> Subject: Re: [U-Boot] [PATCH V2 3/3] edmini: add IDE support >> >> Le 07/07/2010 13:46, Prafulla Wadaskar a ?crit : >> >>>> If you mean 'why not make this a standalone driver, e.g. >>>> driver/net/mvsata_ide.{ch} under a configuration option >>>> CONFIG_MVSATA_IDE' -- why not, but it would basically be empty of >>>> 'driving' functionality (this is handled by cmd_ide) and would only >>>> provide initialization code, subject to board options (e.g. >>>> CONFIG_MVSATA_IDE_ENABLE_PORT{0,1}). >>> >>> then you should add below initialization code in cpu.c for >> respective SoCs >>> and function call here >> >> Ok, but that means duplicating this code across SoCs aven >> though it is >> actually identical for all of them. > > That's why I initially suggested to put it as separate driver than can be used across SoCs. > Even though it is very small code, it makes more sense creating driver for it. Ok then, a driver it is. Amicalement, -- Albert.