public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix condition where bootm_size not set and wrong memory size reported
Date: Thu, 08 Jul 2010 13:43:47 +0400	[thread overview]
Message-ID: <4C359DD3.1030901@mvista.com> (raw)
In-Reply-To: <1278535459-6255-1-git-send-email-msm@freescale.com>

Hello.

Matthew McClintock wrote:

> If the user sets bootm_low and does not set bootm_size, u-boot will
> report the memory node in the flat device tree incorrectly. Instead
> of reporting the remaining size of memory, it will report the total
> available memory which is incorrect.

> Specifically this fixes the situation when booting a relocatable
> kernel and the memory is reported as an offset and size in the
> device tree, and the size needs to be adjusted accordingly.

> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  common/image.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/common/image.c b/common/image.c
> index 2b6007e..bf2acb0 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -433,17 +433,23 @@ ulong getenv_bootm_low(void)
>  
>  phys_size_t getenv_bootm_size(void)
>  {
> +	phys_size_t tmp;
>  	char *s = getenv ("bootm_size");
>  	if (s) {
> -		phys_size_t tmp;
>  		tmp = (phys_size_t)simple_strtoull (s, NULL, 16);
>  		return tmp;
>  	}
> +	s = getenv("bootm_low");
> +	if (s)
> +		tmp = (phys_size_t)simple_strtoull (s, NULL, 16);
> +	else
> +		tmp = 0;
> +
>  
>  #if defined(CONFIG_ARM)
> -	return gd->bd->bi_dram[0].size;
> +	return (gd->bd->bi_dram[0].size - tmp);
>  #else
> -	return gd->bd->bi_memsize;
> +	return (gd->bd->bi_memsize - tmp);

    Parens not useful here and above.

WBR, Sergei

  reply	other threads:[~2010-07-08  9:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-07 20:44 [U-Boot] [PATCH] Fix condition where bootm_size not set and wrong memory size reported Matthew McClintock
2010-07-08  9:43 ` Sergei Shtylyov [this message]
2010-07-08 15:11   ` Matthew McClintock
2010-07-08 22:19     ` Kumar Gala
2010-08-04 18:59       ` Kumar Gala
2010-08-07 19:56     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C359DD3.1030901@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox