From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] kirkwood_egiga: bugfix: add DMA sequence points
Date: Sat, 10 Jul 2010 10:54:21 +0200 [thread overview]
Message-ID: <4C38353D.405@free.fr> (raw)
In-Reply-To: <1278751025-32221-1-git-send-email-albert.aribaud@free.fr>
Please disregard. I have misplaced the second isb().
> @@ -536,6 +538,9 @@ static int kwgbe_send(struct eth_device *dev, volatile void *dataptr,
> p_txdesc->buf_ptr = (u8 *) p;
> p_txdesc->byte_cnt = datasize;
>
> + /* ensure tx desc writes above are performed before we start Tx DMA */
> + isb();
> +
> /* Apply send command using zeroth TXUQ */
> KWGBEREG_WR(regs->tcqdp[TXUQ], (u32) p_txdesc);
> KWGBEREG_WR(regs->tqc, (1<< TXUQ));
It should actually apprear right before the write to tqc.
Resending correct patch.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-07-10 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 8:37 [U-Boot] [PATCH] kirkwood_egiga: bugfix: add DMA sequence points Albert Aribaud
2010-07-10 8:54 ` Albert ARIBAUD [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-07-10 9:01 Albert Aribaud
2010-07-10 13:23 ` Prafulla Wadaskar
2010-07-10 13:36 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C38353D.405@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox