From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Sat, 10 Jul 2010 10:54:21 +0200 Subject: [U-Boot] [PATCH] kirkwood_egiga: bugfix: add DMA sequence points In-Reply-To: <1278751025-32221-1-git-send-email-albert.aribaud@free.fr> References: <1278751025-32221-1-git-send-email-albert.aribaud@free.fr> Message-ID: <4C38353D.405@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Please disregard. I have misplaced the second isb(). > @@ -536,6 +538,9 @@ static int kwgbe_send(struct eth_device *dev, volatile void *dataptr, > p_txdesc->buf_ptr = (u8 *) p; > p_txdesc->byte_cnt = datasize; > > + /* ensure tx desc writes above are performed before we start Tx DMA */ > + isb(); > + > /* Apply send command using zeroth TXUQ */ > KWGBEREG_WR(regs->tcqdp[TXUQ], (u32) p_txdesc); > KWGBEREG_WR(regs->tqc, (1<< TXUQ)); It should actually apprear right before the write to tqc. Resending correct patch. Amicalement, -- Albert.