From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 12 Jul 2010 08:14:15 +0200 Subject: [U-Boot] [PATCH V3 5/5] edminiv2: add ethernet support In-Reply-To: References: <1278835300-10658-1-git-send-email-albert.aribaud@free.fr> <1278835300-10658-2-git-send-email-albert.aribaud@free.fr> <1278835300-10658-3-git-send-email-albert.aribaud@free.fr> <1278835300-10658-4-git-send-email-albert.aribaud@free.fr> <1278835300-10658-5-git-send-email-albert.aribaud@free.fr> <1278835300-10658-6-git-send-email-albert.aribaud@free.fr> Message-ID: <4C3AB2B7.6000803@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Prafulla, Le 12/07/2010 08:00, Prafulla Wadaskar a ?crit : >> +/* >> + * Ethernet >> + */ > > Pls remove additional space char here Done. >> +#define CONFIG_MV_EGIGA /* Enable Marvell egiga >> [...] >> +#define CONFIG_RESET_PHY_R /* use reset_phy() to init >> mv8831116 PHY */ > > Shift above definition below (inside #ifdef CONFIG_CMD_NET), that makes more sense Done--actually replaced "Ethernet" with "Network" in block comment as the whole block is not only about Eth. Thanks for the feedback. Any remaining comments on patches 1-4? Amicalement, -- Albert.