From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 5/5] edminiv2: add ethernet support
Date: Sun, 11 Jul 2010 23:31:06 -0700 [thread overview]
Message-ID: <4C3AB6AA.2070901@gmail.com> (raw)
In-Reply-To: <4C3AB2B7.6000803@free.fr>
Hi Albert,
On 7/11/2010 11:14 PM, Albert ARIBAUD wrote:
> Hi Prafulla,
>
> Le 12/07/2010 08:00, Prafulla Wadaskar a ?crit :
>
>>> +/*
>>> + * Ethernet
>>> + */
>> Pls remove additional space char here
> Done.
>
>>> +#define CONFIG_MV_EGIGA /* Enable Marvell egiga
>>> [...]
>>> +#define CONFIG_RESET_PHY_R /* use reset_phy() to init
>>> mv8831116 PHY */
>> Shift above definition below (inside #ifdef CONFIG_CMD_NET), that makes more sense
> Done--actually replaced "Ethernet" with "Network" in block comment as
> the whole block is not only about Eth.
>
> Thanks for the feedback.
>
> Any remaining comments on patches 1-4?
>
> Amicalement,
That should be it. Please post updates as needed.
regards,
Ben
next prev parent reply other threads:[~2010-07-12 6:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 8:01 [U-Boot] [PATCH V3 0/5] Marvell egiga multiple SoC support Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 1/5] net: rename: kirkwood_egiga as mv_egiga Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 2/5] mv_egiga: support SoCs other than kirkwood Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 3/5] mv_egiga: CONFIG_SKIP_LOCAL_MAC_RANDOMIZATION Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 4/5] mv_egiga: add support for orion5x egiga controller Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 5/5] edminiv2: add ethernet support Albert Aribaud
2010-07-12 6:00 ` Prafulla Wadaskar
2010-07-12 6:14 ` Albert ARIBAUD
2010-07-12 6:31 ` Ben Warren [this message]
2010-07-12 6:05 ` [U-Boot] [PATCH V3 4/5] mv_egiga: add support for orion5x egiga controller Prafulla Wadaskar
2010-07-12 5:53 ` [U-Boot] [PATCH V3 3/5] mv_egiga: CONFIG_SKIP_LOCAL_MAC_RANDOMIZATION Prafulla Wadaskar
2010-07-12 5:45 ` [U-Boot] [PATCH V3 2/5] mv_egiga: support SoCs other than kirkwood Prafulla Wadaskar
2010-07-12 6:23 ` Ben Warren
2010-07-12 6:53 ` Prafulla Wadaskar
2010-07-12 8:53 ` Albert ARIBAUD
2010-07-12 14:19 ` Ben Warren
2010-07-12 15:54 ` Albert ARIBAUD
2010-07-12 16:27 ` Albert ARIBAUD
2010-07-12 5:49 ` Prafulla Wadaskar
2010-07-12 8:56 ` Albert ARIBAUD
2010-07-12 14:23 ` Ben Warren
2010-07-13 5:38 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3AB6AA.2070901@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox