From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Sun, 11 Jul 2010 23:31:06 -0700
Subject: [U-Boot] [PATCH V3 5/5] edminiv2: add ethernet support
In-Reply-To: <4C3AB2B7.6000803@free.fr>
References: <1278835300-10658-1-git-send-email-albert.aribaud@free.fr>	<1278835300-10658-2-git-send-email-albert.aribaud@free.fr>	<1278835300-10658-3-git-send-email-albert.aribaud@free.fr>	<1278835300-10658-4-git-send-email-albert.aribaud@free.fr>	<1278835300-10658-5-git-send-email-albert.aribaud@free.fr>	<1278835300-10658-6-git-send-email-albert.aribaud@free.fr>	<F766E4F80769BD478052FB6533FA745D19A4A5D5FD@SC-VEXCH4.marvell.com>
	<4C3AB2B7.6000803@free.fr>
Message-ID: <4C3AB6AA.2070901@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

  Hi Albert,

On 7/11/2010 11:14 PM, Albert ARIBAUD wrote:
> Hi Prafulla,
>
> Le 12/07/2010 08:00, Prafulla Wadaskar a ?crit :
>
>>> +/*
>>> + * Ethernet
>>> +  */
>> Pls remove additional space char here
> Done.
>
>>> +#define CONFIG_MV_EGIGA		/* Enable Marvell egiga
>>> [...]
>>> +#define CONFIG_RESET_PHY_R	/* use reset_phy() to init
>>> mv8831116 PHY */
>> Shift above definition below (inside #ifdef CONFIG_CMD_NET), that makes more sense
> Done--actually replaced "Ethernet" with "Network" in block comment as
> the whole block is not only about Eth.
>
> Thanks for the feedback.
>
> Any remaining comments on patches 1-4?
>
> Amicalement,
That should be it.  Please post updates as needed.

regards,
Ben