From: Albert ARIBAUD <albert.aribaud@free.fr>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 2/5] mv_egiga: support SoCs other than kirkwood
Date: Mon, 12 Jul 2010 18:27:24 +0200 [thread overview]
Message-ID: <4C3B426C.7080206@free.fr> (raw)
In-Reply-To: <F766E4F80769BD478052FB6533FA745D19A4A5D5F6@SC-VEXCH4.marvell.com>
Le 12/07/2010 07:45, Prafulla Wadaskar a ?crit :
>> --- a/arch/arm/include/asm/arch-kirkwood/kirkwood.h
>> +++ b/arch/arm/include/asm/arch-kirkwood/kirkwood.h
>> +#if defined (CONFIG_MV_EGIGA)
>
> I think you don't need ifdef here
>
>> +#define MV_EGIGA0_BASE KW_EGIGA0_BASE
>> +#define MV_EGIGA1_BASE KW_EGIGA1_BASE
>> +#endif
Actually the ifdef is intended to make sure these symbols do not get
defined uselessly for kirkwood boards that don't have Ethernet support.
Granted, their being defined without being used is no big deal.
However the whole thing about the egiga driver supporting one or two
ports could be streamlined (e.g., one might define KIRKWOOD_EGIGAn_BASE
while not enabling port n in CONFIG_KIRKWOOD_EGIGA_PORTS) and integrate
the suggestion about the PHYs that occurred some time ago:
<http://lists.denx.de/pipermail/u-boot/2010-June/073138.html>
So I'll leave that one to a later patch set.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2010-07-12 16:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-11 8:01 [U-Boot] [PATCH V3 0/5] Marvell egiga multiple SoC support Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 1/5] net: rename: kirkwood_egiga as mv_egiga Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 2/5] mv_egiga: support SoCs other than kirkwood Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 3/5] mv_egiga: CONFIG_SKIP_LOCAL_MAC_RANDOMIZATION Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 4/5] mv_egiga: add support for orion5x egiga controller Albert Aribaud
2010-07-11 8:01 ` [U-Boot] [PATCH V3 5/5] edminiv2: add ethernet support Albert Aribaud
2010-07-12 6:00 ` Prafulla Wadaskar
2010-07-12 6:14 ` Albert ARIBAUD
2010-07-12 6:31 ` Ben Warren
2010-07-12 6:05 ` [U-Boot] [PATCH V3 4/5] mv_egiga: add support for orion5x egiga controller Prafulla Wadaskar
2010-07-12 5:53 ` [U-Boot] [PATCH V3 3/5] mv_egiga: CONFIG_SKIP_LOCAL_MAC_RANDOMIZATION Prafulla Wadaskar
2010-07-12 5:45 ` [U-Boot] [PATCH V3 2/5] mv_egiga: support SoCs other than kirkwood Prafulla Wadaskar
2010-07-12 6:23 ` Ben Warren
2010-07-12 6:53 ` Prafulla Wadaskar
2010-07-12 8:53 ` Albert ARIBAUD
2010-07-12 14:19 ` Ben Warren
2010-07-12 15:54 ` Albert ARIBAUD
2010-07-12 16:27 ` Albert ARIBAUD [this message]
2010-07-12 5:49 ` Prafulla Wadaskar
2010-07-12 8:56 ` Albert ARIBAUD
2010-07-12 14:23 ` Ben Warren
2010-07-13 5:38 ` Prafulla Wadaskar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3B426C.7080206@free.fr \
--to=albert.aribaud@free.fr \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox