From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] fdt: Add fdt_node_offset_by_compat_reg helper
Date: Sat, 17 Jul 2010 22:59:20 -0400 [thread overview]
Message-ID: <4C426E08.6020003@gmail.com> (raw)
In-Reply-To: <89B5F58B-3BBE-4CDD-8F95-04FC4670AA70@kernel.crashing.org>
Hi Kumar,
On 07/17/2010 11:49 AM, Kumar Gala wrote:
>
> On Jul 4, 2010, at 1:18 PM, Kumar Gala wrote:
>
>> Given a compatiable string and physical address try and find a node that
compatible
>> matches. This is useful when we want to find a specific device node to
>> update (for example if we have multiple PCI nodes we can use the
>> physical address to distinquish them when trying to update the device
distinguish (s/q/g/)
>> tree).
>>
>> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
^
Probably should have a space in your signed-off-by line just in case a
SOB line parser is picky.
>> ---
>> common/fdt_support.c | 27 +++++++++++++++++++++++++++
>> include/fdt_support.h | 2 ++
>> 2 files changed, 29 insertions(+), 0 deletions(-)
>
> Jerry,
>
> Any comments?
>
> - k
Looks OK to me other than two typos in the comment.
Acked-by: Gerald Van Baren <vanbaren@cideas.com>
gvb
next prev parent reply other threads:[~2010-07-18 2:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-04 18:18 [U-Boot] [PATCH 1/2] fdt: Add fdt_translate_address to convert reg node to cpu phys addr Kumar Gala
2010-07-04 18:18 ` [U-Boot] [PATCH 2/2] fdt: Add fdt_node_offset_by_compat_reg helper Kumar Gala
2010-07-17 15:49 ` Kumar Gala
2010-07-18 2:59 ` Jerry Van Baren [this message]
2010-07-21 5:35 ` Kumar Gala
2010-07-17 15:49 ` [U-Boot] [PATCH 1/2] fdt: Add fdt_translate_address to convert reg node to cpu phys addr Kumar Gala
2010-07-18 3:00 ` Jerry Van Baren
2010-07-21 5:35 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C426E08.6020003@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox