From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry Van Baren Date: Sat, 17 Jul 2010 23:17:25 -0400 Subject: [U-Boot] [PATCH] always relocate fdt into an lmb-allocated memory block In-Reply-To: <1274731825-10169-1-git-send-email-timur@freescale.com> References: <1274731825-10169-1-git-send-email-timur@freescale.com> Message-ID: <4C427245.6090206@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Timur, On 05/24/2010 04:10 PM, Timur Tabi wrote: > The device tree (fdt) must always exist in within the bootmap (usually the > first 16MB of RAM). If it doesn't, then boot_relocate_fdt() will allocate an > LMB region in the bootmap and copy the fdt into that region. It will also > increase the size of the fdt. > > If the fdt is already in the bootmap, then previously the memory was just > reserved. There was no contingency if the reservation failed, however. > > By always allocating an lmb region and copying/resizing the fdt into that > region, the code is simplified and the memory region is always allocated > properly. > > Also change the types of some variables to avoid some typecasts. > > Signed-off-by: Timur Tabi ^ Need a space in your SOB line? > --- > common/image.c | 83 +++++++++++++++++++------------------------------------- > 1 files changed, 28 insertions(+), 55 deletions(-) I assume this is a "live" patch, and replaces the patch with the subject "libfdt: make fdt_increase_size() available to everyone". It looks like a good improvement to me and nobody threw any stones at it, so... Acked-by: Gerald Van Baren [snip] Best regards, gvb