From: Vipin KUMAR <vipin.kumar@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/28] SPEAr : Supporting various configurations for spear3xx and spear6xx boards
Date: Mon, 19 Jul 2010 09:11:12 +0530 [thread overview]
Message-ID: <4C43C958.7090908@st.com> (raw)
In-Reply-To: <20100716112449.042B9153A82@gemini.denx.de>
On 7/16/2010 4:54 PM, Wolfgang Denk wrote:
> Dear Vipin KUMAR,
>
> I wrote:
>
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -2088,12 +2088,27 @@ omap730p2_cs3boot_config : unconfig
>>> @$(MKCONFIG) -n $@ -a omap730p2 arm arm926ejs omap730p2 ti omap
>>>
>>> spear300_config \
>>> +spear300_nand_config \
>>> +spear300_usbtty_config \
>>> +spear300_usbtty_nand_config \
>>> spear310_config \
>>> -spear320_config : unconfig
>>> - @$(MKCONFIG) -n $@ -t $@ spear3xx arm arm926ejs $(@:_config=) spear spear
>>> -
>>> -spear600_config : unconfig
>>> - @$(MKCONFIG) -n $@ -t $@ spear6xx arm arm926ejs $(@:_config=) spear spear
>>> +spear310_nand_config \
>>> +spear310_usbtty_config \
>>> +spear310_usbtty_nand_config \
>>> +spear320_config \
>>> +spear320_nand_config \
>>> +spear320_usbtty_config \
>>> +spear320_usbtty_nand_config : unconfig
>>> + @$(MKCONFIG) -n $@ -t $@ spear3xx_evb arm arm926ejs $(@:_config=) spear spear
>>> +
>>> +spear600_config \
>>> +spear600_nand_config \
>>> +spear600_usbtty_config \
>>> +spear600_usbtty_nand_config : unconfig
>>> + @$(MKCONFIG) -n $@ -t $@ spear6xx_evb arm arm926ejs $(@:_config=) spear spear
>>> +
>>> +suen3_config: unconfig
>>> + @$(MKCONFIG) $(@:_config=) arm arm926ejs km_arm keymile kirkwood
>>
>> NAK.
>>
>>
>> I don't want to have such stuff in the Makefile any more. Please try
>> to find a way how to do this using boards.cfg instead.
>>
>> [I know that tis is non-trivial; you may want to talk to Detlev about
>> this - he was thinking about the same issue, but I don;t know if he
>> came to any conclusions.]
>
>
> I discussed this topic with Detlev. This is the suggestion we came up
> with:
>
> - At the moment, the first fieled in the boards.cfg file is used to
> determine the name of the board configuration file.
> - We will now extend this and allow for additional configuration
> parameters to be appended.
> - Unlike in the Makefile, where we were restricted by the make
> syntax, we suggest to use a comma as separator character.
> - There can be an arbitrary number of such parameters (zero or more),
> but of course the list should be kept short to keep the file
> readable.
> - The configuration parameters can take the simple form "name" (as we
> use now in the Makefile) or "name=value".
> - The code in "mkconfig" that processes these parameters (similar to
> what the "-t" option is doing now) will translate a plain "name"
> entry into a "#define CONFIG_MK_<name> 1", and a "name=value" entry
> into "#define CONFIG_MK_<name> value".
>
>
> In the result, instead of adding these lines to the Makefile:
>
> +spear310_nand_config \
> +spear310_usbtty_config \
> +spear310_usbtty_nand_config \
> +spear320_config \
> +spear320_nand_config \
> +spear320_usbtty_config \
> +spear320_usbtty_nand_config : unconfig
> + @$(MKCONFIG) -n $@ -t $@ spear3xx_evb arm arm926ejs $(@:_config=) spear spear
>
> we would add these lines to the boards.cfg file:
>
> spear310 arm arm926ejs arm926ejs spear310 spear spear
> spear310,nand arm arm926ejs arm926ejs spear310 spear spear
> spear310,usbtty arm arm926ejs arm926ejs spear310 spear spear
> spear310,usbtty,nand arm arm926ejs arm926ejs spear310 spear spear
> spear320 arm arm926ejs arm926ejs spear310 spear spear
> spear320,nand arm arm926ejs arm926ejs spear310 spear spear
> spear320,usbtty arm arm926ejs arm926ejs spear310 spear spear
> spear320,usbtty,nand arm arm926ejs arm926ejs spear310 spear spear
>
>
Dear Wolfgang,
Got it. This is nice. Clears up a little mess in the Makefile
I would make the changes as suggested.
Thanks..
Regards
Vipin
>
> What do you think?
>
> Best regards,
>
> Wolfgang Denk
>
next prev parent reply other threads:[~2010-07-19 3:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 5:09 [U-Boot] [PATCH 00/28] Support for SPEAr13xx boards added Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 01/28] change_bit routine defined Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 02/28] SPEAr : SMI erase and write timeouts increased Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 03/28] SPEAr : Placing ethaddr write and read within CONFIG_CMD_NET Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 04/28] SPEAr : Reducing the max RAM size to 128MB Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 05/28] SPEAr : Basic arch related support added for SPEAr SoCs Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 06/28] SPEAr : Network support configured for spear SoCs Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 07/28] SPEAr : macb driver support added for spear310 and spear320 Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 08/28] SPEAr : FSMC driver support added Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 09/28] SPEAr : Configuring FSMC driver for NAND interface Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 10/28] SPEAr : i2c driver moved completely into drivers/i2c Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 11/28] SPEAr : smi driver moved completely into drivers/mtd Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 12/28] SPEAr : USB Device Controller driver support added Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 13/28] SPEAr : Supporting various configurations for spear3xx and spear6xx boards Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 14/28] SPEAr : Basic spear1300 architecture support added Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 15/28] SPEAr : spear1300 SoC " Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 16/28] SPEAr : Removing extraneous code Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 17/28] SPEAr : USB device controller bugfixes Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 18/28] SPEAr : Network driver fixes Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 19/28] SPEAr : Changing the default environment variable bootargs Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 20/28] SPEAr1300: Workaround the UHC problem (issue #101435) Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 21/28] Enable high speed support for usb device framework and usbtty Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 22/28] SPEAr : High speed support for designware peripheral Vipin KUMAR
2010-07-14 5:09 ` [U-Boot] [PATCH 23/28] SPEAr : Enable usb device high speed support Vipin KUMAR
2010-07-14 5:10 ` [U-Boot] [PATCH 24/28] SPEAr : Network support configuration Vipin KUMAR
2010-07-14 5:10 ` [U-Boot] [PATCH 25/28] SPEAr : Enabling GPT clock explicitly Vipin KUMAR
2010-07-14 5:10 ` [U-Boot] [PATCH 26/28] SPEAr : smi_init moved to board_init Vipin KUMAR
2010-07-14 5:10 ` [U-Boot] [PATCH 27/28] SPEAr : Ethernet issue workaround is not needed when uboot is acting as flashing Vipin KUMAR
2010-07-14 5:10 ` [U-Boot] [PATCH 28/28] SPEAr1310 : spear1310 support added Vipin KUMAR
2010-07-15 22:14 ` Wolfgang Denk
2010-07-15 22:12 ` [U-Boot] [PATCH 27/28] SPEAr : Ethernet issue workaround is not needed when uboot is acting as flashing Wolfgang Denk
2010-07-15 22:10 ` [U-Boot] [PATCH 25/28] SPEAr : Enabling GPT clock explicitly Wolfgang Denk
2010-07-15 22:09 ` [U-Boot] [PATCH 24/28] SPEAr : Network support configuration Wolfgang Denk
2010-08-01 11:06 ` [U-Boot] [PATCH 22/28] SPEAr : High speed support for designware peripheral Remy Bohmer
2010-07-15 22:08 ` [U-Boot] [PATCH 21/28] Enable high speed support for usb device framework and usbtty Wolfgang Denk
2010-08-01 11:11 ` [U-Boot] [PATCH 17/28] SPEAr : USB device controller bugfixes Remy Bohmer
2010-07-15 22:04 ` [U-Boot] [PATCH 15/28] SPEAr : spear1300 SoC support added Wolfgang Denk
2010-07-16 4:45 ` Vipin KUMAR
2010-07-15 22:01 ` [U-Boot] [PATCH 14/28] SPEAr : Basic spear1300 architecture " Wolfgang Denk
2010-07-15 21:55 ` [U-Boot] [PATCH 13/28] SPEAr : Supporting various configurations for spear3xx and spear6xx boards Wolfgang Denk
2010-07-16 11:24 ` Wolfgang Denk
2010-07-16 11:41 ` Reinhard Meyer
2010-07-19 3:41 ` Vipin KUMAR [this message]
2010-08-01 11:08 ` [U-Boot] [PATCH 12/28] SPEAr : USB Device Controller driver support added Remy Bohmer
2010-07-15 21:41 ` [U-Boot] [PATCH 08/28] SPEAr : FSMC " Wolfgang Denk
2010-07-15 21:38 ` [U-Boot] [PATCH 07/28] SPEAr : macb driver support added for spear310 and spear320 Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C43C958.7090908@st.com \
--to=vipin.kumar@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox