From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Mon, 19 Jul 2010 16:02:23 -0700 Subject: [U-Boot] [PATCH v2] net, fec: fix "Warning: eth device name has a space!" for FEC devices In-Reply-To: <20100719225711.20B4E14EB09@gemini.denx.de> References: <4C44C8F9.6020904@denx.de> <20100719225711.20B4E14EB09@gemini.denx.de> Message-ID: <4C44D97F.2090005@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Heiko, On 7/19/2010 3:57 PM, Wolfgang Denk wrote: > Dear Heiko Schocher, > > In message<4C44C8F9.6020904@denx.de> you wrote: >> since commit 1384f3bb8a4f9066805b70c1418eda78ecb73fdd ethernet names >> with spaces drop a >> >> Warning: eth device name has a space! >> >> message. This patch fix it for: >> >> - "FEC ETHERNET" devices found on >> mpc512x, mpc5xxx, mpc8xx and mpc8220 boards. >> renamed to "FEC". >> - "SCC ETHERNET" devices found on >> mpc8xx, mpc82xx based boards. Renamed to "SCC". >> - "HDLC ETHERNET" devices found on mpc8xx boards >> Renamed to "HDLC" >> - "FCC ETHERNET" devices found on mpc8260 and mpc85xx based >> boards. Renamed to "FCC" > The Subject: (which is way too long, btw.) does not match the content > of this patch. > > > I'm not sure if it is a good idea to change the board specific > README's. For example, board/LEOX/elpt860/README.LEOX shows > > U-Boot 0.2.2 ... > ... > Net: SCC ETHERNET > > For this specific version, the string was correct. Changing it is > technically not correct. > > Best regards, > > Wolfgang Denk > I just ran MAKEALL on this and it's clean, so if you address Wolfgang's concerns we'll pull it in. regards, Ben